Featuretensor refactor - #29
Merged
Merged
Conversation
Knight-X
commented
Nov 1, 2017
Knight-X
commented
Member
- pass tensorIdx TEST
- add basic context class
- replace tensor with tensor
- make ram tensor which is inherited from tensor with Type
1. extend different type tensor for sd, memory 2. inherit super class for polymorphism
Context dev
1. test idea quickly 2. sync idea 3. take type from tensor 4. make type system in ramtensor
1. implement add function 2. implement customized ram tensor constructor
…ensor into featuretensor_refactor
…r into feature_tensor_ref
Feature tensor ref initial merge commit
neil-tan
approved these changes
Nov 2, 2017
neil-tan
left a comment
neil-tan
left a comment
Member
There was a problem hiding this comment.
not yet tested, waiting for context and ops' merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.