us_update_socket_context() and ability to specify inline key/cert#231
Open
partyblob wants to merge 7 commits intouNetworking:masterfrom
Open
us_update_socket_context() and ability to specify inline key/cert#231partyblob wants to merge 7 commits intouNetworking:masterfrom
partyblob wants to merge 7 commits intouNetworking:masterfrom
Conversation
Author
|
Added fixes for #211 |
Update examples
Author
|
Added partial solution to #29 via
struct addrinfo *us_get_addr(const char* host, int port);
void us_free_addr(struct addrinfo *addr);
struct us_socket_t *us_socket_context_connect_addr(int ssl, struct us_socket_context_t *context, const struct addrinfo *host, const char *source_host, int options, int socket_ext_size);Note that dependencies need not include headers for |
Contributor
|
No way I can merge this as one MR, you need to separate it into multiple smaller Mrs with clear separation of concern. Otherwise, I'm positive 👍 |
Author
Yeah I didn't realise making commits after a PR updates the PR, I'll separate into branches when I get home |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds the ability to reload
us_socket_context_options_tfor a socket context viarather than by workarounds like add_server_name (which rely on SNI callbacks and do not work for situations like wildcard or shared certificates)
As well as the ability to specify certificate, private key, CA and dh-params as raw data rather than file paths
which is available via the new us_socket_context_options_t interface