Removed Updater methods - #750
Open
Miha22 wants to merge 15 commits into
Open
Conversation
1. Rebuilt Rocket Mod 4.9.3.0 with UnityEngine.CoreModule. Take in mind: - Due to Unturned update, UnityEngine namespace is now a part of UnityEngine.CoreModule - Rocket Mod version 4.9.3.0 is referencing UnityEngine(before update). Explanation: When updating plugin, we reference new libraries, so did I. I referenced uEssentials to new library (UnityEngine.CoreModule), but appeared an error "need a reference to UnityEngine", but I have referenced UnityEngine.CoreModule, which contained UnityEngine. and I was just wtf wtf wtf.. but then I realized that Rocket is not referencing UnityEngine.CoreModule, so I rebuilt rocket especailly for uEssentials. 2. Methods updating: /repair - updated /repair command and added 2 child commands /reapair all /repair <player name> - added support for console, so now you can execute the command from console, of course I added understandable exception handling as well (Rocket Logging). 2. Methods updating: /killanimals - Dont remember what was wrong here, maybe it jsut needed an UnityEngine. 3. FrozenPlayer.cs fix. - replaced method with new one.
- removed useless method.
To comply with the harbor rules, Updater was disabled.
Author
|
Removed Updater methods |
- changed project target .NET to 4 from 4.6.1
- removed useless logging of unvehicled player
I have no idea why in event of 1 vehicle in VehicleManager.vehicles List.RemoveAt(0) throws IndexOutOfRangeException. Literally a bug that cannot be solved from plugin. Thats why to execute this command without any errors, an executor sometimes should use /clear ev 2-3 times.
zientix
suggested changes
Jul 22, 2020
| { | ||
| case (0): | ||
| if (caller is ConsolePlayer) | ||
| Rocket.Core.Logging.Logger.LogException(new System.InvalidOperationException($"Console does not have an iventory to repair! You must be a player to execute /repair or /fix")); |
There was a problem hiding this comment.
you typed iventory instead of inventory ofc
Author
There was a problem hiding this comment.
damn I thought you found something essential.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Take in mind:
Explanation:
When updating plugin, we reference new libraries, so did I.
I referenced uEssentials to new library (UnityEngine.CoreModule), but appeared an error "need a reference to UnityEngine", but I have referenced UnityEngine.CoreModule, which contained UnityEngine. and I was just wtf wtf wtf..
but then I realized that Rocket is not referencing UnityEngine.CoreModule, so I rebuilt rocket especailly for uEssentials.