uefivars: Add boot option parsing for MBR disks#3490
Merged
Conversation
dxing97
force-pushed
the
mbr-support
branch
3 times, most recently
from
bd7eab6 to
2729de3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3490 +/- ##
==========================================
+ Coverage 61.72% 61.75% +0.02%
==========================================
Files 646 646
Lines 43721 43746 +25
==========================================
+ Hits 26987 27014 +27
+ Misses 16734 16732 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Member
|
Try fix DCO failure, |
10000TB
added
Awaiting reviewer
andrewsun2898
requested changes
Jan 27, 2026
This change adds FilterMBRSig to blockdev to find devices matching a given MBR signature. It also implements the UEFI boot option parsing for SigType 1, which uses the MBR signature and partition number to identify the boot device. Test cases are added for FilterMBRSig, MBR device path nodes, and resolving MBR disks. Signed-off-by: Daniel Xing <danielxing97@gmail.com>
Contributor
Author
|
added a test for resolving a MBR boot option |
dxing97
added
Awaiting reviewer
rminnich
reviewed
Jan 31, 2026
Member
rminnich
left a comment
rminnich
left a comment
There was a problem hiding this comment.
This is getting there. Thanks so much for this contribution. Let's get this one down, and it guide the next two.
Signed-off-by: Daniel Xing <danielxing97@gmail.com>
Signed-off-by: Daniel Xing <danielxing97@gmail.com>
rminnich
approved these changes
Feb 6, 2026
Member
rminnich
left a comment
rminnich
left a comment
There was a problem hiding this comment.
looks ok, I wonder why the CI failed. Let's try it again.
rminnich
previously approved these changes
Feb 7, 2026
andrewsun2898
previously approved these changes
Feb 9, 2026
10000TB
reviewed
Feb 9, 2026
Member
|
( Looks like I never published my comments : / -- better than never -- just sharing, since this is already submitted) |
Signed-off-by: Daniel Xing <danielxing97@gmail.com>
10000TB
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds FilterMBRSig to blockdev to find devices matching a given MBR signature. It also implements the UEFI boot option parsing for SigType 1, which uses the MBR signature and partition number to identify the boot device. Test cases are added for FilterMBRSig.