Only reserve MMCONFIG on x86 platforms#3472
Merged
Merged
Conversation
andrewsun2898
force-pushed
the
upl2
branch
2 times, most recently
from
73ac756 to
00e59ce
Compare
Member
|
any idea how could we prevent such in u-root CI for future ? |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3472 +/- ##
=======================================
Coverage 61.83% 61.84%
=======================================
Files 637 637
Lines 43113 43121 +8
=======================================
+ Hits 26661 26668 +7
- Misses 16452 16453 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Reserving the MMCONFIG is required on x86 platforms to ensure that PCI devices work properly in the OS. In ARM, UPL uses device trees to discover PCI devices, which can cause conflicts if the MMCONFIG regions are reserved. Tested: Booted UPL on ARM platform and verified boot. Booted x86 platform and verified regions are reserved. Signed-off-by: Andrew Sun <andrewsun@google.com>
Contributor
Author
A VM test that runs through UPL and perform sanity checks in the final OS could be a good way to verify UPL related changes. |
10000TB
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.