Skip to content

move golangci-lint to config file#2912

Merged
hugelgupf merged 5 commits into
u-root:mainfrom
binjip978:linter-rework
Feb 15, 2024
Merged

move golangci-lint to config file#2912
hugelgupf merged 5 commits into
u-root:mainfrom
binjip978:linter-rework

Conversation

@binjip978
Copy link
Copy Markdown
Contributor

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4420d1b) 78.21% compared to head (1511286) 78.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2912   +/-   ##
=======================================
  Coverage   78.21%   78.22%           
=======================================
  Files         421      421           
  Lines       42893    42893           
=======================================
+ Hits        33550    33553    +3     
+ Misses       9343     9340    -3     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.41% <ø> (+0.02%) ⬆️
integration/generic-tests/...-amd64 20.51% <ø> (ø)
integration/generic-tests/...-arm 11.70% <ø> (ø)
integration/generic-tests/...-arm64 23.98% <ø> (ø)
integration/gotests/...-amd64 74.69% <ø> (ø)
integration/gotests/...-arm 76.04% <ø> (ø)
integration/gotests/...-arm64 75.93% <ø> (-0.08%) ⬇️
pkg/...-amd64 76.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binjip978 binjip978 force-pushed the linter-rework branch 2 times, most recently from 55fe54b to 6e5299e Compare February 10, 2024 06:09
@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Feb 10, 2024
@binjip978
Copy link
Copy Markdown
Contributor Author

now it can be run locally

go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.56.0
GOOS=linux GOARCH=amd64 golangci-lint run

Comment thread .github/workflows/golangci-lint.yml
Comment thread .github/workflows/golangci-lint.yml
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Copy link
Copy Markdown
Contributor

@RiSKeD RiSKeD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice changes. It might break the scope of this PR, but it would be nice to enable more linters. It really depends on the amount of refactoring necessary.

@binjip978
Copy link
Copy Markdown
Contributor Author

nice changes. It might break the scope of this PR, but it would be nice to enable more linters. It really depends on the amount of refactoring necessary.

yes some of the checks will be easy to fix, but probably it will be better to do in next PR.

@hugelgupf hugelgupf merged commit f89966d into u-root:main Feb 15, 2024
@binjip978 binjip978 deleted the linter-rework branch February 15, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants