Skip to content

pkg/dhclient: wrap errors#2863

Merged
hugelgupf merged 1 commit into
u-root:mainfrom
binjip978:dhcpclient
Jan 22, 2024
Merged

pkg/dhclient: wrap errors#2863
hugelgupf merged 1 commit into
u-root:mainfrom
binjip978:dhcpclient

Conversation

@binjip978
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (5e702f0) 75.69% compared to head (31e71bb) 75.70%.

Files Patch % Lines
pkg/dhclient/dhcp4.go 0.00% 3 Missing ⚠️
pkg/dhclient/dhclient.go 0.00% 2 Missing ⚠️
pkg/dhclient/dhcp6.go 0.00% 1 Missing ⚠️
pkg/dhclient/iface.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2863   +/-   ##
=======================================
  Coverage   75.69%   75.70%           
=======================================
  Files         425      425           
  Lines       42832    42832           
=======================================
+ Hits        32423    32425    +2     
+ Misses      10409    10407    -2     
Flag Coverage Δ
.-amd64 67.87% <ø> (ø)
cmds/...-amd64 71.43% <ø> (ø)
integration/generic-tests/...-amd64 0.00% <ø> (ø)
integration/generic-tests/...-arm 0.00% <ø> (ø)
integration/generic-tests/...-arm64 0.00% <ø> (ø)
integration/gotests/...-amd64 73.98% <22.22%> (ø)
integration/gotests/...-arm 75.27% <22.22%> (+0.07%) ⬆️
integration/gotests/...-arm64 74.93% <22.22%> (+<0.01%) ⬆️
pkg/...-amd64 76.14% <22.22%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Jan 22, 2024
@hugelgupf hugelgupf merged commit 3d52f7b into u-root:main Jan 22, 2024
@binjip978 binjip978 deleted the dhcpclient branch January 23, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants