Introduce basic test for pkg/tss#2722
Merged
Merged
Conversation
This change introduces support for running a pkg/tss test if there is a running TPM simulator. The TPM command and platform command ports must be passed to the test via command-line flags, otherwise the test will be script. This change introduces a small, basic test for testing the Info() function. Other tests for PCR and NV functionality will come in later PRs. A side-effect of this change is that the rest of the relevant packages inside go-tpm are pulled into the vendor directory so that other u-root users can use them. These packages are: * go-tpm/tpm2 (the new direct API) * go-tpm/tpm2/transport (the interface for all TPM transport types) * go-tpm/tpmutil/mssim (bindings for the TCP simulator) Signed-off-by: Chris Fenner <cfenn@google.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #2722 +/- ##
==========================================
+ Coverage 75.38% 75.58% +0.19%
==========================================
Files 414 412 -2
Lines 42229 42103 -126
==========================================
- Hits 31836 31823 -13
+ Misses 10393 10280 -113
☔ View full report in Codecov by Sentry. |
Member
|
very cool. If you can please set the label in future to awaiting reviewer so I make sure to notice. |
Member
Author
Ah thanks, sorry I missed the existence of this label before. Thanks for taking a look! |
rminnich
approved these changes
Jul 18, 2023
rminnich
added
the
Awaiting author
Member
Author
|
@hugelgupf is free to also take a look but removing him from the request to -- the amount of things taking up his time :) |
chrisfenner
added
Awaiting author
chrisfenner
removed
the
Awaiting author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces support for running a pkg/tss test if there is a running TPM simulator. The TPM command and platform command ports must be passed to the test via command-line flags, otherwise the test will be skipped.
This change introduces a small, basic test for testing the Info() function. Other tests for PCR and NV functionality will come in later PRs.
A side-effect of this change is that the rest of the relevant packages inside go-tpm are pulled into the vendor directory so that other u-root users can use them. These packages are: