Skip to content

cmds/core/sort: ignore blanks break ties by length#2697

Merged
binjip978 merged 1 commit into
u-root:mainfrom
binjip978:blanks
Jun 19, 2023
Merged

cmds/core/sort: ignore blanks break ties by length#2697
binjip978 merged 1 commit into
u-root:mainfrom
binjip978:blanks

Conversation

@binjip978
Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9c6acc6) 75.42% compared to head (d2fd347) 75.42%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2697   +/-   ##
=======================================
  Coverage   75.42%   75.42%           
=======================================
  Files         414      414           
  Lines       42151    42159    +8     
=======================================
+ Hits        31792    31799    +7     
- Misses      10359    10360    +1     
Impacted Files Coverage Δ
cmds/core/sort/sort.go 90.67% <100.00%> (+0.67%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Jun 17, 2023
Copy link
Copy Markdown
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm beginning to understand how companies used to exist by only selling a sort product.

(look up syncsort ...)

@rminnich rminnich added Awaiting author Waiting for new changes or feedback for author. and removed Awaiting reviewer Waiting for a reviewer. labels Jun 19, 2023
@binjip978 binjip978 merged commit 97bd852 into u-root:main Jun 19, 2023
@binjip978
Copy link
Copy Markdown
Contributor Author

I'm beginning to understand how companies used to exist by only selling a sort product.

(look up syncsort ...)

They still selling it https://www.precisely.com/product/precisely-syncsort/syncsort-mfx :)

@binjip978 binjip978 deleted the blanks branch June 20, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting author Waiting for new changes or feedback for author.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants