Skip to content

sort -C and -u flags#2691

Merged
binjip978 merged 5 commits into
u-root:mainfrom
binjip978:some-sort-flags
Jun 9, 2023
Merged

sort -C and -u flags#2691
binjip978 merged 5 commits into
u-root:mainfrom
binjip978:some-sort-flags

Conversation

@binjip978
Copy link
Copy Markdown
Contributor

No description provided.

@binjip978 binjip978 changed the title Some sort flags sort -C flag Jun 3, 2023
@binjip978 binjip978 added the Awaiting reviewer Waiting for a reviewer. label Jun 3, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 3, 2023

Codecov Report

Patch coverage: 90.56% and no project coverage change.

Comparison is base (b4273b0) 75.37% compared to head (e78eb14) 75.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2691   +/-   ##
=======================================
  Coverage   75.37%   75.38%           
=======================================
  Files         414      414           
  Lines       42056    42083   +27     
=======================================
+ Hits        31701    31725   +24     
- Misses      10355    10358    +3     
Impacted Files Coverage Δ
cmds/core/sort/sort.go 85.33% <90.56%> (+2.00%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@binjip978 binjip978 changed the title sort -C flag sort -C and -u flags Jun 3, 2023
Copy link
Copy Markdown
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

substantial improvement! I note the one spelling change.

Comment thread cmds/core/sort/sort_test.go Outdated
binjip978 added 4 commits June 7, 2023 04:33
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Signed-off-by: Siarhiej Siemianczuk <pdp.eleven11@gmail.com>
Comment thread cmds/core/sort/sort.go
@binjip978 binjip978 merged commit a87349c into u-root:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants