Skip to content

HSS: Support reading HSS from EEPROM#2690

Merged
10000TB merged 1 commit into
u-root:mainfrom
ylchenfj:main
Jun 5, 2023
Merged

HSS: Support reading HSS from EEPROM#2690
10000TB merged 1 commit into
u-root:mainfrom
ylchenfj:main

Conversation

@ylchenfj
Copy link
Copy Markdown
Contributor

@ylchenfj ylchenfj commented Jun 1, 2023

This change adds an option for nvme_unlock to read HSS keys from EEPROM. We assume the EEPROMs will be enumerated in sysfs and can be accessed like a regular file.

@ylchenfj ylchenfj added the Awaiting reviewer Waiting for a reviewer. label Jun 2, 2023
@10000TB 10000TB requested a review from a team June 2, 2023 02:45
Comment thread pkg/hsskey/filereader.go
Comment thread pkg/hsskey/filereader.go Outdated
Comment thread pkg/hsskey/filereader.go
Comment thread pkg/hsskey/filereader.go Outdated
Comment thread pkg/hsskey/filereader.go Outdated
Comment thread pkg/hsskey/filereader_test.go Outdated
Comment thread pkg/hsskey/hsskey.go Outdated
Comment thread pkg/hsskey/hsskey.go Outdated
Copy link
Copy Markdown
Member

@10000TB 10000TB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2023

Codecov Report

Patch coverage: 76.59% and project coverage change: +0.03 🎉

Comparison is base (4d6e8c7) 75.36% compared to head (1c558cd) 75.40%.

❗ Current head 1c558cd differs from pull request most recent head 3b343b7. Consider uploading reports for the commit 3b343b7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2690      +/-   ##
==========================================
+ Coverage   75.36%   75.40%   +0.03%     
==========================================
  Files         413      414       +1     
  Lines       41961    42053      +92     
==========================================
+ Hits        31625    31709      +84     
- Misses      10336    10344       +8     
Impacted Files Coverage Δ
pkg/hsskey/hsskey.go 25.00% <0.00%> (-7.70%) ⬇️
pkg/hsskey/filereader.go 94.73% <94.73%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

This change adds an option for nvme_unlock to read HSS keys from EEPROM.
We assume the EEPROMs will be enumerated in sysfs and can be accessed like
a regular file.

Signed-off-by: Yulong Chen <yulongchen@google.com>
@10000TB 10000TB merged commit 2c62ceb into u-root:main Jun 5, 2023
@ylchenfj ylchenfj removed the Awaiting reviewer Waiting for a reviewer. label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants