cmds/core/gosh: reintroduce nocomp mode without bubbline#2685
Conversation
|
it turned out completion was not the only issue, which is why I renamed things. bubbline insists on putting out all this ansi foo, for its fancy prompts and such, and that caused trouble for testing scripts. Also there was the size issue. So, I'd suggest it is not about completion, it is about complexity, and I like your use of the name simple. We ought to find a way to integrate this with the stuff I upstreamed already. One question, though: the code I upstreamed works. Given that, what is the extra value of this PR? What am I missing? |
|
I was ooo yesterday. I already thought of a way integrating your change. Let me rebase this PR so we can choose between bubbline and no editline implementation for automated testing via a fleg/env var without any regression in shell parsing functionality. |
|
I have implemented a change within google that does this but using the old "prompt" code in our copy. |
MDr164
force-pushed
the
unlcutter_gosh
branch
2 times, most recently
from
d012211 to
4301816
Compare
It showed that this library causes quite a few issues in automated test, so the default will be the plain sh interactive mode which is much more slimmed down. Bubbline can be enabled during runtime still using the comp flag. Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Signed-off-by: Marvin Drees <marvin.drees@9elements.com>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
- Coverage 75.43% 75.34% -0.09%
==========================================
Files 414 414
Lines 42168 42205 +37
==========================================
- Hits 31810 31800 -10
- Misses 10358 10405 +47
☔ View full report in Codecov by Sentry. |
rminnich
left a comment
rminnich
left a comment
There was a problem hiding this comment.
this looks a lot better than what I did.
|
it appears you want to do more, and now I wonder: |
3 participants
It showed that this library causes quite a few issues in automated test, so the default will be the plain sh interactive mode which is much more slimmed down. Bubbline can be enabled during runtime still using the comp flag.