Skip to content

Tinygoupdate#2647

Merged
rminnich merged 6 commits into
u-root:mainfrom
rminnich:tinygoupdate
Apr 6, 2023
Merged

Tinygoupdate#2647
rminnich merged 6 commits into
u-root:mainfrom
rminnich:tinygoupdate

Conversation

@rminnich
Copy link
Copy Markdown
Member

@rminnich rminnich commented Apr 4, 2023

updating gzip as part of tinygo updating, and because it needed some cleanup. There is more to do, of course. I just want to see what the tools think of the coverage (beside it being worse)

rminnich added 4 commits April 3, 2023 16:10
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2023

Codecov Report

Patch coverage: 62.50% and no project coverage change.

Comparison is base (353626c) 75.02% compared to head (c9199b2) 75.03%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2647   +/-   ##
=======================================
  Coverage   75.02%   75.03%           
=======================================
  Files         413      413           
  Lines       41760    41760           
=======================================
+ Hits        31332    31334    +2     
+ Misses      10428    10426    -2     
Impacted Files Coverage Δ
pkg/gzip/file.go 77.77% <62.50%> (+4.16%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

rminnich added 2 commits April 3, 2023 20:56
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
The Process function needs rework, as it hardwires stdin.

Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
@rminnich rminnich added the Awaiting reviewer Waiting for a reviewer. label Apr 4, 2023
@rminnich rminnich requested review from a team, bensallen and binjip978 April 4, 2023 23:09
@rminnich rminnich merged commit 51c802d into u-root:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Awaiting reviewer Waiting for a reviewer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants