Introduce ipmi.OpenPath and make blobs.BlobStats public.#2621
Merged
Conversation
Codecov ReportBase: 75.03% // Head: 74.88% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2621 +/- ##
==========================================
- Coverage 75.03% 74.88% -0.16%
==========================================
Files 411 411
Lines 41557 41568 +11
==========================================
- Hits 31184 31127 -57
- Misses 10373 10441 +68
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
hugelgupf
reviewed
Feb 17, 2023
This change makes two minor feature updates to the ipmi and blobs packages: 1. Introduces OpenPath to open the ipmi device by full path instead of just device number. 2. Makes BlobStats's members public, so that BlobStat and BlobSessionStat can be used. In testing this change, I noticed that BlobStat/BlobSessionStat had a bug. Fixed that as well. (You can't pass a struct with a slice member to binary.Read.) Signed-off-by: Chris Fenner <cfenn@google.com>
rminnich
reviewed
Feb 21, 2023
Signed-off-by: Chris Fenner <cfenn@google.com>
hugelgupf
approved these changes
Feb 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes two minor feature updates to the ipmi and blobs packages:
Introduces OpenPath to open the ipmi device by full path instead of just device number.
Makes BlobStats's members public, so that BlobStat and BlobSessionStat can be used.
In testing this change, I noticed that BlobStat/BlobSessionStat had a bug. Fixed that as well. (You can't pass a struct with a slice member to binary.Read.)