cmds/core/cmp: major cleanup; cmds/core/comm: minor cleanup, tinygo test works for both now#2612
Merged
Merged
Conversation
Codecov ReportBase: 74.88% // Head: 74.85% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 74.88% 74.85% -0.03%
==========================================
Files 408 408
Lines 41380 41380
==========================================
- Hits 30986 30974 -12
- Misses 10394 10406 +12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rminnich
changed the title
cmp did not match the standard cmp in some important ways, revealed by tinygo testing. So: fix error handling to return wrapped errors and defined types fix stderr to print real errors fix stdout to print file differences, if any print nothing if files are identical remove the chans, which did not properly communicate EOF anyway cmp now correctly passes tinygo test Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
comm now uses the errors packages, and works now for tinygo Signed-off-by: Ronald G. Minnich <rminnich@gmail.com>
rjoleary
approved these changes
Feb 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmp did not match the standard cmp in some important ways, revealed by tinygo testing.
So:
fix error handling to return wrapped errors and defined types
fix stderr to print real errors
fix stdout to print file differences, if any
print nothing if files are identical
remove the chans, which did not properly communicate EOF anyway
cmp now correctly passes
tinygo test
Signed-off-by: Ronald G. Minnich rminnich@gmail.com