TODO: Fix tests

we probably ought to get this done or close it.

we probably ought to get this done or close it.

I'll be getting it in shape this week and fix the unit tests.

Codecov Report

Patch coverage: 39.82% and project coverage change: +3.05 🎉

Comparison is base (bcd2ee0) 69.07% compared to head (b4eec4b) 72.13%.

❗ Current head b4eec4b differs from pull request most recent head 82325a2. Consider uploading reports for the commit 82325a2 to get more accurate results

@@            Coverage Diff             @@
##             main    #2606      +/-   ##
==========================================
+ Coverage   69.07%   72.13%   +3.05%     
==========================================
  Files         112      354     +242     
  Lines        6452    37386   +30934     
==========================================
+ Hits         4457    26970   +22513     
- Misses       1995    10416    +8421     

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

we probably ought to get this done or close it.

Ready for review and testing

Bubbleline is not a repo with a lot of public interests atm, and it carries a series dependencies on other repos

Did we agree it is a repo we can rely on ? -- asking to see if it is worth importing in for our internal use case.
It means we have to pull in all its dependent repos in order to use Bubbleline. Without reasonable number of
public adoptions, I would be concerned with the reliability, and it potentially increasing security attach surface

Appreciate you all's replies here soon -- need a decision soon as we need latest version of u-root to resolve a list of issues.

@rminnich @MDr164 @mvdan

did we consider submitting contributions for the "more features" into go-promopt ?

ping

Well go-prompt is dead and has several issue that need fixing. I don't have the capacities to do so, so if you want to maintain go-prompt and fix all the open issues then we can revert that change. Bubbline is a fairly young project, that's why there is not so much "public interest" yet (also not sure how you measure that). Bubbline has none of the aforementioned issues and Raphael is still actively maintaining this repository. I'm not familiar with your internal guidelines but from a purely open-source perspective bubbline fixes more issues than it creates.

One of the the main issues raised here is that Bubbleline itself assembles features implementations from an array of other new GitHub repos.

Pulling in new uroot, means importing in Bubbleline into our software supply chain. That also mean we import / download the same array of GitHub repos bubbline depends on to be able to build bubbline.

Bubbline repo is not self sufficient (on standard golang libraries).

We are looking at 2+ weeks of SWE hours to set up all dependencies needed by bubbline.

I don't believe we need the new features, but we would need bear the setup cost that bubbline brings in.

ping