Skip to content

cmds/core/shasum: work with multiple files#2525

Merged
rminnich merged 1 commit into
u-root:mainfrom
binjip978:shasum-multiple-files
Oct 14, 2022
Merged

cmds/core/shasum: work with multiple files#2525
rminnich merged 1 commit into
u-root:mainfrom
binjip978:shasum-multiple-files

Conversation

@binjip978
Copy link
Copy Markdown
Contributor

Signed-off-by: Siarhiej Siemianchuk pdp.eleven11@gmail.com

Signed-off-by: Siarhiej Siemianchuk <pdp.eleven11@gmail.com>
@binjip978
Copy link
Copy Markdown
Contributor Author

Is it worse to handle - case? Dash is currently not handled in cat as well, but it's easy to add.

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 14, 2022

Codecov Report

Base: 73.73% // Head: 73.90% // Increases project coverage by +0.16% 🎉

Coverage data is based on head (b199621) compared to base (8757e8f).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2525      +/-   ##
==========================================
+ Coverage   73.73%   73.90%   +0.16%     
==========================================
  Files         403      403              
  Lines       40937    40938       +1     
==========================================
+ Hits        30184    30254      +70     
+ Misses      10753    10684      -69     
Impacted Files Coverage Δ
cmds/core/shasum/shasum.go 87.50% <100.00%> (+0.32%) ⬆️
pkg/acpi/rsdp.go 51.28% <0.00%> (+10.25%) ⬆️
pkg/acpi/raw.go 89.28% <0.00%> (+14.28%) ⬆️
pkg/acpi/bios.go 83.78% <0.00%> (+83.78%) ⬆️
pkg/acpi/sdt.go 86.66% <0.00%> (+86.66%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Member

@rminnich rminnich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep those PRs coming, you've almost got us to 74%!

@rminnich rminnich merged commit 49ddb74 into u-root:main Oct 14, 2022
@binjip978 binjip978 deleted the shasum-multiple-files branch November 15, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants