Add -cmdline to fbnetboot to override kernel cmdline args#2524
Merged
Conversation
When booting with a manually-specified image (e.g. via `netboot-url`) it is often useful to be able to apply custom kernel command line arguments. This adds a `-cmdline` argument in the same style as the `netboot-url` argument, to override the default (typically empty) value. Signed-off-by: Elliot Saba <staticfloat@gmail.com>
staticfloat
force-pushed
the
sf/override_cmdline
branch
from
2931fed to
9a342f6
Compare
Codecov ReportBase: 73.73% // Head: 73.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2524 +/- ##
==========================================
+ Coverage 73.73% 73.90% +0.16%
==========================================
Files 403 403
Lines 40937 40937
==========================================
+ Hits 30184 30253 +69
+ Misses 10753 10684 -69
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rminnich
approved these changes
Oct 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When booting with a manually-specified image (e.g. via
netboot-url) it is often useful to be able to apply custom kernel command line arguments. This adds a-cmdlineargument in the same style as thenetboot-urlargument, to override the default (typically empty) value.