Codecov Report

Base: 73.90% // Head: 73.74% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (47d0847) compared to base (49ddb74).
Patch coverage: 96.66% of modified lines in pull request are covered.

@@            Coverage Diff             @@
##             main    #2520      +/-   ##
==========================================
- Coverage   73.90%   73.74%   -0.16%     
==========================================
  Files         403      403              
  Lines       40938    40949      +11     
==========================================
- Hits        30254    30199      -55     
- Misses      10684    10750      +66     

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

circleci is in a bad place lately

seems like circleci worked this time

I realized I have two questions.

1. The standard unix way to do this: tr A-Z a-z file | uniq. Is there a real need for -i
2. we'd like to make u-root conform more to posix, and this is not in posix

request: fix coverage issue.

I realized I have two questions.

1. The standard unix way to do this: tr A-Z a-z file | uniq. Is there a real need for -i
2. we'd like to make u-root conform more to posix, and this is not in posix

Yea I agree there are now need to -i flag and it's definitely not part of posix https://pubs.opengroup.org/onlinepubs/9699919799/utilities/uniq.html, but it was requested explicitly in roadmap.md so I decided to add it, also -i is a part of freebsd, linux and macOS uniq so maybe some people need it.

But I agree it's better idea to remove it, but not 100% sure, due the roadmap request.

@rminnich probably I messed up with force push, but it reports other files in coverage diff, but it should be improved

I really appreciate you paying attention to the roadmap! Thank you!

I guess if this is felt to be important, we can accept it?

I'm ok to accept it, if it was required in roadmap, maybe it save some typing time for someone :)

In this case, because we know that some script or makefile will break if we do not support it, I guess we can accept -i!

Thanks for your careful reading of the roadmap and your contribution.