update golang version of project and testimages to 1.19#2510
Conversation
|
Will remain in draft until I am able to push the updated docker images to docker hub. |
|
@rminnich one last release on 1.17 before the bump? |
|
so ... how do you folks feel about 1.20? It has the new error trees instead of error chains stuff. Or at least the PR went in ... maybe we need 1.21? multierror is SO MUCH NICER with error trees. |
I mean go 1.20 is scheduled for February 2023, is your plan to keep this PR on halt until then to skip directly to 1.20? I think 1.18 is a reasonable bump as 1.19 is the current latest release and quite a few potentially necessary things got added in 1.18. I mean improved error handling is nice, but I don't think it's holding out for a version bump that long if 1.18 brings things we could need. Or am I misinterpreting the comment? |
|
@rminnich I built the docker images and ran the tests for go 1.19 locally as well. It really depends on if we want to move up to the latest version to be up-to-date or stick to 1.18 to enable more functionality. Either way, in my opinion bumping up now to at least go 1.18 comes with new opportunities like the native golang fuzzing support. |
RiSKeD
force-pushed
the
golang-version-bump-to-1.18
branch
from
8f9506c to
d4f4754
Compare
|
Fixed up a small issue regarding the working directory because of the newer cimg/go image. |
RiSKeD
force-pushed
the
golang-version-bump-to-1.18
branch
from
9885bba to
e54b83e
Compare
RiSKeD
changed the title
|
@rminnich There is a test TestNoActionDoubleWait in the syscallfilter pkg, which never returns due to a change in the handling of Wait() in the os/exec pkg for go1.19. The expected error in the test is never returned because of this and just idles. Could you take a look at it? Thanks |
|
see #2519 |
RiSKeD
force-pushed
the
golang-version-bump-to-1.18
branch
from
e54b83e to
10c7643
Compare
Codecov ReportBase: 73.73% // Head: 73.90% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
+ Coverage 73.73% 73.90% +0.17%
==========================================
Files 403 403
Lines 40937 40937
==========================================
+ Hits 30183 30253 +70
+ Misses 10754 10684 -70
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rminnich
left a comment
rminnich
left a comment
There was a problem hiding this comment.
this is a hard review given the insane amount of seemingly unnecessary reformatting ... The only thing that puzzled me is the # in the comment in that one go file. I guess the reformatting comes with the territoty.
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
Signed-off-by: Fabian Wienand <fabian.wienand@9elements.com>
RiSKeD
force-pushed
the
golang-version-bump-to-1.18
branch
from
cdd462d to
9cd1a2b
Compare
MDr164
left a comment
MDr164
left a comment
There was a problem hiding this comment.
Not sure if the go doc change in 1.19 caused you to reformat the package docs but I went through all of them and the changes all look sane, The content of the docs is unmodified and they are all uniform now to the go package doc spec. As the CI runs through and the changes to bump us to 1.19 are minimal I'll approve this PR. I also recently marked a new tag (v0.10.0) in case you want to jump back to 1.17
4 participants
To include native golang fuzzing tests in u-root, a version bump to golang version 1.18 is necessary.
The testimage-amd64 Dockerfile uses the latest commit of multiboot-test-kernel with updated build flags.
Signed-off-by: Fabian Wienand fabian.wienand@9elements.com