Join consecutive inline links - #8797
Draft
PgBiel wants to merge 14 commits into
Draft
Conversation
- also attempt to use links() instead of entries() - break on empty link
Member
|
Actually #6248 is already implemented, but only enabled when exporting PDF/UA-1 documents, because there isn't wide-spread support for quadpoints in PDF viewers. |
PgBiel
force-pushed
the
collect-links
branch
2 times, most recently
from
September 1, 2026 03:11
85dc46f to
715c547
Compare
(todo: consider if this is desirable as is, cf. equations)
fix pdf panics
logical indices ignore RTL reordering. This fixes RTL. Note that RTL reordering might cause links to become discontinuous, so the code includes a check that creates separate link boundaries as needed.
PgBiel
force-pushed
the
collect-links
branch
from
September 11, 2026 04:36
f126c99 to
fdceccc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR essentially transfers responsibility of making text links clickable from each piece of text to the paragraph's line layout. This allows joining consecutive link bounding boxes together in a single line, ensuring a single
#linkcall generates a single clickable area (for each line).(Notably, this does not address #6248, as each line will still produce a different link bounding box, but could definitely be a step forward in that direction.)
By introducing the necessary infrastructure to detect changes in styles mid-paragraph (particularly link styles), this PR is thus the first step before moving decoration handling to paragraphs as well, in order to fix various issues under #7802.
I've attempted to cleanup commit history a bit (not fully), so checking commit-by-commit should be possible if that's desirable.
TODO
#hide