Skip to content

fix(eslint-plugin): [method-signature-style] ignore methods that return this #11813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoshuaKGoldberg merged 5 commits into from
Dec 16, 2025
Merged

fix(eslint-plugin): [method-signature-style] ignore methods that return this #11813

JoshuaKGoldberg merged 5 commits into from
Dec 16, 2025
+191 −42

Conversation

@JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Dec 1, 2025

PR Checklist

Overview

Adds a utility method to recurse through the AST similar to ts.forEachChild.

💖

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Dec 1, 2025

Thanks for the PR, @JoshuaKGoldberg!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Dec 1, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 99cb780
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/6941205ccd24650008a017c7
😎 Deploy Preview https://deploy-preview-11813--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (🟢 up 17 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Dec 1, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 99cb780

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 10s View ↗
nx run-many -t lint ✅ Succeeded 3m 17s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 11s View ↗
nx run integration-tests:test ✅ Succeeded 7s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 5s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 2s View ↗
nx run types:build ✅ Succeeded 2s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-12-16 09:15:54 UTC

@codecov
Copy link

codecov bot commented Dec 1, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 98.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.58%. Comparing base (5ac66a6) to head (99cb780).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
packages/eslint-plugin/src/util/astUtils.ts 95.34% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11813      +/-   ##
==========================================
+ Coverage   90.53%   90.58%   +0.04%     
==========================================
  Files         523      524       +1     
  Lines       53097    53382     +285     
  Branches     8838     8912      +74     
==========================================
+ Hits        48074    48357     +283     
- Misses       5010     5012       +2     
  Partials       13       13
Flag Coverage Δ
unittest 90.58% <98.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
.../eslint-plugin/src/rules/method-signature-style.ts 93.88% <100.00%> (+0.42%) ⬆️
packages/eslint-plugin/src/util/astUtils.ts 95.78% <95.34%> (-0.37%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg requested review from a team and removed request for a team December 1, 2025 16:12
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as draft December 1, 2025 16:15
@JoshuaKGoldberg JoshuaKGoldberg marked this pull request as ready for review December 1, 2025 18:48
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team December 1, 2025 18:48
ronami
ronami previously approved these changes Dec 15, 2025
View reviewed changes
Copy link
Member

@ronami ronami left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀 Looking good, small comment from me regarding code coverage.

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 15, 2025
@github-actions github-actions bot removed the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 16, 2025
ronami
ronami approved these changes Dec 16, 2025
View reviewed changes
Copy link
Member

@ronami ronami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@ronami ronami added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Dec 16, 2025
@JoshuaKGoldberg JoshuaKGoldberg merged commit 6882a09 into typescript-eslint:main Dec 16, 2025
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ronami ronami ronami approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[method-signature-style] Shouldn't affect methods that use this

2 participants

@JoshuaKGoldberg @ronami