Skip to content

fix(eslint-plugin): honor ignored base types on generic classes #11767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoshuaKGoldberg merged 3 commits into from
Nov 28, 2025
Merged

fix(eslint-plugin): honor ignored base types on generic classes #11767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bef61e2
fix(eslint-plugin): honor ignored base types on generic classes
OleksandraKordonets Nov 19, 2025
3d0cf2a
Merge branch 'main' into issue11758
JoshuaKGoldberg Nov 24, 2025
52a4d74
Address feedback: apply review style suggestions
OleksandraKordonets Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 20 additions & 12 deletions packages/eslint-plugin/src/rules/no-base-to-string.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,14 +211,26 @@ export default createRule<Options, MessageIds>({
return Usefulness.Always;
}

function hasBaseTypes(type: ts.Type): type is ts.InterfaceType {
return (
tsutils.isObjectType(type) &&
function getBaseTypesForType(type: ts.Type): readonly ts.Type[] {
if (!tsutils.isObjectType(type)) {
return [];
}

const interfaceTarget = tsutils.isTypeReference(type)
? type.target
: type;

const interfaceType =
tsutils.isObjectFlagSet(
type,
interfaceTarget,
ts.ObjectFlags.Interface | ts.ObjectFlags.Class,
)
);
) && (interfaceTarget as ts.InterfaceType);

if (!interfaceType) {
return [];
}

return checker.getBaseTypes(interfaceType);
}

function isIgnoredTypeOrBase(
Expand All @@ -231,13 +243,9 @@ export default createRule<Options, MessageIds>({

seen.add(type);

const typeName = getTypeName(checker, type);
return (
ignoredTypeNames.includes(typeName) ||
(hasBaseTypes(type) &&
checker
.getBaseTypes(type)
.some(base => isIgnoredTypeOrBase(base, seen)))
ignoredTypeNames.includes(getTypeName(checker, type)) ||
getBaseTypesForType(type).some(base => isIgnoredTypeOrBase(base, seen))
);
}

Expand Down
15 changes: 15 additions & 0 deletions packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,6 +334,21 @@ declare const error: MyError;
error.toString();
`,
},
{
code: `
class BaseError extends Error {
code?: string;
}
class Boom<T> extends BaseError {
details: T;
}
function bar<T>(error: Boom<T>) {
console.log(error.toString());
}
`,
},
{
code: `
class UnknownBase {}
Expand Down