typescript-eslint · JoshuaKGoldberg · Nov 24, 2025 · Nov 14, 2025 · Nov 14, 2025 · Nov 14, 2025
diff --git a/...-spec/src/parameter/TSParameterProperty/fixtures/_error_/array-binding-pattern/fixture.ts b/...-spec/src/parameter/TSParameterProperty/fixtures/_error_/array-binding-pattern/fixture.ts
@@ -0,0 +1 @@
+class Test { constructor(private [foo] = [1]) {} }
diff --git a/...SParameterProperty/fixtures/_error_/array-binding-pattern/snapshots/1-TSESTree-Error.shot b/...SParameterProperty/fixtures/_error_/array-binding-pattern/snapshots/1-TSESTree-Error.shot
diff --git a/...r/TSParameterProperty/fixtures/_error_/array-binding-pattern/snapshots/2-Babel-Error.shot b/...r/TSParameterProperty/fixtures/_error_/array-binding-pattern/snapshots/2-Babel-Error.shot
diff --git a/...ParameterProperty/fixtures/_error_/array-binding-pattern/snapshots/3-Alignment-Error.shot b/...ParameterProperty/fixtures/_error_/array-binding-pattern/snapshots/3-Alignment-Error.shot
diff --git a/...spec/src/parameter/TSParameterProperty/fixtures/_error_/object-binding-pattern/fixture.ts b/...spec/src/parameter/TSParameterProperty/fixtures/_error_/object-binding-pattern/fixture.ts
@@ -0,0 +1 @@
+class Test { constructor(private { bar } = { bar: 1 }) {} }
diff --git a/...ParameterProperty/fixtures/_error_/object-binding-pattern/snapshots/1-TSESTree-Error.shot b/...ParameterProperty/fixtures/_error_/object-binding-pattern/snapshots/1-TSESTree-Error.shot
diff --git a/.../TSParameterProperty/fixtures/_error_/object-binding-pattern/snapshots/2-Babel-Error.shot b/.../TSParameterProperty/fixtures/_error_/object-binding-pattern/snapshots/2-Babel-Error.shot
diff --git a/...arameterProperty/fixtures/_error_/object-binding-pattern/snapshots/3-Alignment-Error.shot b/...arameterProperty/fixtures/_error_/object-binding-pattern/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/parameter/TSParameterProperty/fixtures/_error_/rest-element/fixture.ts b/packages/ast-spec/src/parameter/TSParameterProperty/fixtures/_error_/rest-element/fixture.ts
@@ -0,0 +1 @@
+class Test { constructor(private ...baz) {} }
diff --git a/...rameter/TSParameterProperty/fixtures/_error_/rest-element/snapshots/1-TSESTree-Error.shot b/...rameter/TSParameterProperty/fixtures/_error_/rest-element/snapshots/1-TSESTree-Error.shot
diff --git a/.../parameter/TSParameterProperty/fixtures/_error_/rest-element/snapshots/2-Babel-Error.shot b/.../parameter/TSParameterProperty/fixtures/_error_/rest-element/snapshots/2-Babel-Error.shot
diff --git a/...ameter/TSParameterProperty/fixtures/_error_/rest-element/snapshots/3-Alignment-Error.shot b/...ameter/TSParameterProperty/fixtures/_error_/rest-element/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/src/parameter/TSParameterProperty/spec.ts b/packages/ast-spec/src/parameter/TSParameterProperty/spec.ts
@@ -1,17 +1,20 @@
 import type { AST_NODE_TYPES } from '../../ast-node-types';
 import type { Accessibility } from '../../base/Accessibility';
 import type { BaseNode } from '../../base/BaseNode';
+import type { Identifier } from '../../expression/Identifier/spec';
 import type { Decorator } from '../../special/Decorator/spec';
-import type { BindingName } from '../../unions/BindingName';
 import type { AssignmentPattern } from '../AssignmentPattern/spec';
-import type { RestElement } from '../RestElement/spec';
+
+type ParameterPropertyParameter =
+  | (AssignmentPattern & { left: Identifier })
+  | Identifier;
 
 export interface TSParameterProperty extends BaseNode {
   type: AST_NODE_TYPES.TSParameterProperty;
   accessibility: Accessibility | undefined;
   decorators: Decorator[];
   override: boolean;
-  parameter: AssignmentPattern | BindingName | RestElement;
+  parameter: ParameterPropertyParameter;
   readonly: boolean;
   static: boolean;
 }
diff --git a/packages/ast-spec/tests/fixtures-with-differences-errors.shot b/packages/ast-spec/tests/fixtures-with-differences-errors.shot
diff --git a/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts b/packages/eslint-plugin/src/rules/explicit-member-accessibility.ts
@@ -359,19 +359,10 @@ export default createRule<Options, MessageIds>({
       node: TSESTree.TSParameterProperty,
     ): void {
       const nodeType = 'parameter property';
-      // HAS to be an identifier or assignment or TSC will throw
-      if (
-        node.parameter.type !== AST_NODE_TYPES.Identifier &&
-        node.parameter.type !== AST_NODE_TYPES.AssignmentPattern
-      ) {
-        return;
-      }
-
       const nodeName =
         node.parameter.type === AST_NODE_TYPES.Identifier
           ? node.parameter.name
-          : // has to be an Identifier or TSC will throw an error
-            (node.parameter.left as TSESTree.Identifier).name;
+          : (node.parameter.left as TSESTree.Identifier).name;
 
       switch (paramPropCheck) {
         case 'explicit': {

diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-parameter-property-assignment.ts b/packages/eslint-plugin/src/rules/no-unnecessary-parameter-property-assignment.ts
@@ -109,8 +109,7 @@ export default createRule({
         ((node.parameter.type === AST_NODE_TYPES.Identifier && // constructor (public foo) {}
           node.parameter.name === name) ||
           (node.parameter.type === AST_NODE_TYPES.AssignmentPattern && // constructor (public foo = 1) {}
-            node.parameter.left.type === AST_NODE_TYPES.Identifier &&
-            node.parameter.left.name === name))
+            (node.parameter.left as TSESTree.Identifier).name === name))
       );
     }
 

diff --git a/packages/eslint-plugin/src/rules/parameter-properties.ts b/packages/eslint-plugin/src/rules/parameter-properties.ts
@@ -107,19 +107,10 @@ export default createRule<Options, MessageIds>({
           const modifiers = getModifiers(node);
 
           if (!allow.includes(modifiers)) {
-            // HAS to be an identifier or assignment or TSC will throw
-            if (
-              node.parameter.type !== AST_NODE_TYPES.Identifier &&
-              node.parameter.type !== AST_NODE_TYPES.AssignmentPattern
-            ) {
-              return;
-            }
-
             const name =
               node.parameter.type === AST_NODE_TYPES.Identifier
                 ? node.parameter.name
-                : // has to be an Identifier or TSC will throw an error
-                  (node.parameter.left as TSESTree.Identifier).name;
+                : (node.parameter.left as TSESTree.Identifier).name;
 
             context.report({
               node,

diff --git a/packages/eslint-plugin/src/util/class-scope-analyzer/extractComputedName.ts b/packages/eslint-plugin/src/util/class-scope-analyzer/extractComputedName.ts
@@ -59,22 +59,11 @@ function extractNonComputedName(
  */
 export function extractNameForMember(node: MemberNode): ExtractedName | null {
   if (node.type === AST_NODE_TYPES.TSParameterProperty) {
-    switch (node.parameter.type) {
-      case AST_NODE_TYPES.ArrayPattern:
-      case AST_NODE_TYPES.ObjectPattern:
-      case AST_NODE_TYPES.RestElement:
-        // Nonsensical properties -- see https://github.com/typescript-eslint/typescript-eslint/issues/11708
-        return null;
-
-      case AST_NODE_TYPES.AssignmentPattern:
-        if (node.parameter.left.type !== AST_NODE_TYPES.Identifier) {
-          return null;
-        }
-        return extractNonComputedName(node.parameter.left);
-
-      case AST_NODE_TYPES.Identifier:
-        return extractNonComputedName(node.parameter);
-    }
+    const identifier =
+      node.parameter.type === AST_NODE_TYPES.Identifier
+        ? node.parameter
+        : (node.parameter.left as TSESTree.Identifier);
+    return extractNonComputedName(identifier);
   }
 
   if (node.computed) {

diff --git a/packages/eslint-plugin/src/util/collectUnusedVariables.ts b/packages/eslint-plugin/src/util/collectUnusedVariables.ts
@@ -141,22 +141,18 @@ class UnusedVarsVisitor extends Visitor {
   }
 
   protected TSParameterProperty(node: TSESTree.TSParameterProperty): void {
-    let identifier: TSESTree.Identifier | null = null;
+    let identifier: TSESTree.Identifier;
     switch (node.parameter.type) {
       case AST_NODE_TYPES.AssignmentPattern:
-        if (node.parameter.left.type === AST_NODE_TYPES.Identifier) {
-          identifier = node.parameter.left;
-        }
+        identifier = node.parameter.left as TSESTree.Identifier;
         break;
 
       case AST_NODE_TYPES.Identifier:
         identifier = node.parameter;
         break;
     }
 
-    if (identifier) {
-      this.markVariableAsUsed(identifier);
-    }
+    this.markVariableAsUsed(identifier);
   }
 
   private collectUnusedVariables(

diff --git a/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts b/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts
@@ -302,14 +302,6 @@ class Test {
     },
     {
       code: `
-class Test {
-  constructor(private { x }: any[]) {}
-}
-      `,
-      options: [{ accessibility: 'no-public' }],
-    },
-    {
-      code: `
 class Test {
   #foo = 1;
   #bar() {}

diff --git a/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts b/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts
@@ -1382,27 +1382,16 @@ export class Test {
     {
       code: `
 export class Test {
-  constructor(
-    public foo,
-    private ...bar,
-  ) {}
+  constructor(public foo) {}
 }
       `,
       errors: [
         {
-          column: 12,
+          column: 22,
           data: {
             name: 'foo',
           },
-          line: 4,
-          messageId: 'missingArgType',
-        },
-        {
-          column: 5,
-          data: {
-            name: 'bar',
-          },
-          line: 5,
+          line: 3,
           messageId: 'missingArgType',
         },
       ],

diff --git a/packages/eslint-plugin/tests/rules/parameter-properties.test.ts b/packages/eslint-plugin/tests/rules/parameter-properties.test.ts
@@ -113,18 +113,6 @@ class Foo {
       `,
       options: [{ allow: ['public readonly', 'private'] }],
     },
-    // Semantically invalid test case
-    `
-class Foo {
-  constructor(private ...name: string[]) {}
-}
-    `,
-    // Semantically invalid test case
-    `
-class Foo {
-  constructor(private [test]: [string]) {}
-}
-    `,
     {
       code: `
 class Foo {

diff --git a/packages/typescript-estree/src/check-modifiers.ts b/packages/typescript-estree/src/check-modifiers.ts
@@ -370,6 +370,24 @@ export function checkModifiers(node: ts.Node): void {
           'A parameter property is only allowed in a constructor implementation.',
         );
       }
+      const param = node as ts.ParameterDeclaration;
+
+      if (param.dotDotDotToken) {
+        throwError(
+          modifier,
+          'A parameter property cannot be a rest parameter.',
+        );
+      }
+
+      if (
+        param.name.kind === SyntaxKind.ArrayBindingPattern ||
+        param.name.kind === SyntaxKind.ObjectBindingPattern
+      ) {
+        throwError(
+          modifier,
+          'A parameter property may not be declared using a binding pattern.',
+        );
+      }
     }
 
     // There are more cases in `checkGrammarObjectLiteralExpression` in TypeScript.

diff --git a/packages/typescript-estree/src/convert.ts b/packages/typescript-estree/src/convert.ts
@@ -1823,7 +1823,7 @@ export class Converter {
             accessibility: getTSNodeAccessibility(node),
             decorators: [],
             override: hasModifier(SyntaxKind.OverrideKeyword, node),
-            parameter: result,
+            parameter: result as TSESTree.TSParameterProperty['parameter'],
             readonly: hasModifier(SyntaxKind.ReadonlyKeyword, node),
             static: hasModifier(SyntaxKind.StaticKeyword, node),
           });
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		class Test { constructor(private [foo] = [1]) {} }
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1 @@
		class Test { constructor(private { bar } = { bar: 1 }) {} }