Skip to content

fix(scope-manager): change unhelpful aaa error message and change analyze to expects Program #11747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradzacher merged 4 commits into from
Nov 23, 2025
Merged

fix(scope-manager): change unhelpful aaa error message and change analyze to expects Program #11747

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10ec9df
fix: analyze should be passed Program
nayounsang Nov 9, 2025
b490d8b
fix: throw useful msg when error
nayounsang Nov 9, 2025
e1b53f5
test: add test for throwing err
nayounsang Nov 9, 2025
1282ebc
docs: enhance err msg
nayounsang Nov 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/scope-manager/src/analyze.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const DEFAULT_OPTIONS: Required<AnalyzeOptions> = {
* Takes an AST and returns the analyzed scopes.
*/
export function analyze(
tree: TSESTree.Node,
tree: TSESTree.Program,
providedOptions?: AnalyzeOptions,
): ScopeManager {
const options: Required<AnalyzeOptions> = {
Expand Down
5 changes: 4 additions & 1 deletion packages/scope-manager/src/referencer/Referencer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,10 @@ export class Referencer extends Visitor {
public currentScope(throwOnNull: true): Scope | null;
public currentScope(dontThrowOnNull?: true): Scope | null {
if (!dontThrowOnNull) {
assert(this.scopeManager.currentScope, 'aaa');
assert(
this.scopeManager.currentScope,
'Expected currentScope to exist. This usually happens when analyze() is called with an incomplete AST node instead of a complete Program node.',
);
}
return this.scopeManager.currentScope;
}
Expand Down
16 changes: 16 additions & 0 deletions packages/scope-manager/tests/analyze.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
import { analyze } from '../src';
import { parse } from './test-utils';

describe('analyze()', () => {
it('should throw error when passed a partial AST node', () => {
const ast = parse(`const hello: string = 'world';`, {
range: true,
});
const partialNode = ast.body[0];

expect(() => {
// @ts-expect-error -- to reproduce https://github.com/typescript-eslint/typescript-eslint/issues/11727
analyze(partialNode);
}).toThrow();
});
});
Loading