fix(eslint-plugin-internal): correct documentation URLs with undefined version #11736
Conversation
|
Thanks for the PR, @azat-io! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
View your CI Pipeline Execution ↗ for commit 0909429
☁️ Nx Cloud last updated this comment at |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11736 +/- ##
==========================================
- Coverage 90.66% 90.64% -0.02%
==========================================
Files 518 518
Lines 52435 52435
Branches 8686 8686
==========================================
- Hits 47541 47532 -9
- Misses 4880 4889 +9
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
2 participants
Fixed broken documentation URLs in
@typescript-eslint/eslint-plugin-internalrules that were showingvundefinedin the path.The internal plugin package is private and didn't have a
versionfield inpackage.json, causingundefinedto be interpolated into documentation URLs.Before:
https://github.com/typescript-eslint/typescript-eslint/blob/vundefined/packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts
After:
https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin-internal/src/rules/no-dynamic-tests.ts