fix(eslint-plugin): handle override modifier in promise-function-async fixer #11730
Conversation
|
Thanks for the PR, @sushichan044! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. |
✅ Deploy Preview for typescript-eslint ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sushichan044
changed the title
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run integration-tests:test |
❌ Failed | 53s | View ↗ |
nx test eslint-plugin --coverage=false |
✅ Succeeded | 5m 7s | View ↗ |
nx run-many -t lint |
✅ Succeeded | 3m 12s | View ↗ |
nx run-many -t typecheck |
✅ Succeeded | 2m 1s | View ↗ |
nx test eslint-plugin-internal --coverage=false |
✅ Succeeded | 4s | View ↗ |
nx test typescript-estree --coverage=false |
✅ Succeeded | 1s | View ↗ |
nx run types:build |
✅ Succeeded | 5s | View ↗ |
nx run generate-configs |
✅ Succeeded | 5s | View ↗ |
Additional runs (29) |
✅ Succeeded | ... | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-10-31 12:17:18 UTC
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11730 +/- ##
=======================================
Coverage 90.66% 90.66%
=======================================
Files 518 518
Lines 52415 52417 +2
Branches 8678 8678
=======================================
+ Hits 47521 47523 +2
Misses 4880 4880
Partials 14 14
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
Integration test is failing but not seems like caused by this PR. |
JoshuaKGoldberg
added
the
1 approval
2 participants
PR Checklist
Overview
This PR fixes the promise-function-async rule's fixer to correctly handle the override modifier when inserting the async keyword into method declarations.
The fixer was incorrectly placing async before override, generating invalid TypeScript syntax. The root cause was that the token-skipping logic only handled Keyword type tokens, but TypeScript's override is actually an Identifier token.
The fix extends the while loop condition to also skip Identifier tokens with the value 'override', ensuring that async is inserted in the correct position according to TypeScript's modifier order specification.