Skip to content

feat(typescript-estree): gate all errors behind allowInvalidAST #11693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(typescript-estree): gate all errors behind allowInvalidAST #11693

wants to merge 1 commit into from
+27 −36

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Oct 11, 2025

PR Checklist

Overview

Currently, these errors are all syntax errors, and having two methods is confusing. Let's put all these errors behind allowInvalidAST option.

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Oct 11, 2025

Thanks for the PR, @fisker!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Oct 11, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit 9e06baf
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/68ea1c5e5513e0000817ffd7
😎 Deploy Preview https://deploy-preview-11693--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 97 (no change from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Oct 11, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 9e06baf

Command Status Duration Result
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 16s View ↗
nx run-many -t lint ✅ Succeeded 3m 15s View ↗
nx run-many -t typecheck ✅ Succeeded 1m 53s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 21s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 12s View ↗
nx run integration-tests:test ✅ Succeeded 3s View ↗
nx run types:build ✅ Succeeded 6s View ↗
nx run generate-configs ✅ Succeeded 6s View ↗
Additional runs (29) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-10-11 09:12:35 UTC

@codecov
Copy link

codecov bot commented Oct 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 29.62963% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.68%. Comparing base (de1fedb) to head (9e06baf).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
packages/typescript-estree/src/convert.ts 29.62% 19 Missing ⚠️

❌ Your patch check has failed because the patch coverage (29.62%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #11693      +/-   ##
==========================================
+ Coverage   90.67%   90.68%   +0.01%     
==========================================
  Files         518      518              
  Lines       52466    52458       -8     
  Branches     8694     8695       +1     
==========================================
- Hits        47571    47569       -2     
+ Misses       4881     4874       -7     
- Partials       14       15       +1
Flag Coverage Δ
unittest 90.68% <29.62%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/typescript-estree/src/convert.ts 31.07% <29.62%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: remove Converter#throwUnlessAllowInvalidAST() feat(typescript-estree): gate all errors behind allowInvalidAST Nov 3, 2025
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Nov 3, 2025
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand this, it's actually a pretty big change for the conversion logic, right? If so - that makes sense to me, and I think it's actually quite nice to put all the syntax errors behind the "should the converter throw on invalid syntax?" option. But someone else from @typescript-eslint/triage-team should probably gut check this too.

@JoshuaKGoldberg JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees

No one assigned

Labels

1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fisker @JoshuaKGoldberg