Skip to content

chore: disable fail fast behavior for unit tests #11441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: disable fail fast behavior for unit tests #11441

wants to merge 1 commit into from

Conversation

@kirkwaiblinger
Copy link
Member

@kirkwaiblinger kirkwaiblinger commented Jul 31, 2025 •
edited
Loading

PR Checklist

Overview

@typescript-eslint
Copy link
Contributor

typescript-eslint bot commented Jul 31, 2025

Thanks for the PR, @kirkwaiblinger!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

@netlify
Copy link

netlify bot commented Jul 31, 2025 •
edited
Loading

✅ Deploy Preview for typescript-eslint ready!

Name Link
🔨 Latest commit f01a900
🔍 Latest deploy log https://app.netlify.com/projects/typescript-eslint/deploys/688bae404e82990008fe1765
😎 Deploy Preview https://deploy-preview-11441--typescript-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 95 (🔴 down 3 from production)
Accessibility: 97 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link

nx-cloud bot commented Jul 31, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f01a900

Command Status Duration Result
nx run integration-tests:test ❌ Failed 54s View ↗
nx test ast-spec ❌ Failed 11s View ↗
nx run ast-spec:test -- --coverage ❌ Failed 12s View ↗
nx test eslint-plugin --coverage=false ✅ Succeeded 5m 7s View ↗
nx run-many -t lint ✅ Succeeded 3m 20s View ↗
nx run-many -t typecheck ✅ Succeeded 2m 15s View ↗
nx test typescript-estree --coverage=false ✅ Succeeded 20s View ↗
nx test eslint-plugin-internal --coverage=false ✅ Succeeded 9s View ↗
Additional runs (27) ✅ Succeeded ... View ↗

☁️ Nx Cloud last updated this comment at 2025-07-31 18:08:24 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JamesHenry JamesHenry Awaiting requested review from JamesHenry JamesHenry will be requested when the pull request is marked ready for review JamesHenry is a code owner

@bradzacher bradzacher Awaiting requested review from bradzacher bradzacher will be requested when the pull request is marked ready for review bradzacher is a code owner

@JoshuaKGoldberg JoshuaKGoldberg Awaiting requested review from JoshuaKGoldberg JoshuaKGoldberg will be requested when the pull request is marked ready for review JoshuaKGoldberg is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Repo: Prevent fail-fast behavior for unit tests

1 participant

@kirkwaiblinger