fix(typescript-estree): infers singleRun as true for project service #11327

nayounsang · 2025-06-21T11:06:41Z

PR Checklist

Addresses an existing open issue: fixes Bug(typescript-estree): never infers singleRun as true for project service #9854
That issue was marked as accepting prs
Steps in Contributing were taken

Overview

As project is null when projectService is true, we have to fix validate logic

typescript-eslint · 2025-06-21T11:06:44Z

Thanks for the PR, @nayounsang!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!

🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint.

netlify · 2025-06-21T11:06:54Z

✅ Deploy Preview for typescript-eslint ready!

Name	Link
🔨 Latest commit	`b483190`
🔍 Latest deploy log	https://app.netlify.com/projects/typescript-eslint/deploys/6909f96ce4a3fa0008cc3099
😎 Deploy Preview	https://deploy-preview-11327--typescript-eslint.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 91 (🔴 down 5 from production) Accessibility: 97 (no change from production) Best Practices: 100 (no change from production) SEO: 92 (no change from production) PWA: 80 (no change from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2025-06-21T11:07:58Z

View your CI Pipeline Execution ↗ for commit b483190

Command	Status	Duration	Result
`nx test eslint-plugin --coverage=false`	✅ Succeeded	5m 21s	View ↗
`nx run-many -t lint`	✅ Succeeded	3m 13s	View ↗
`nx run-many -t typecheck`	✅ Succeeded	1m 54s	View ↗
`nx test typescript-estree --coverage=false`	✅ Succeeded	19s	View ↗
`nx test eslint-plugin-internal --coverage=false`	✅ Succeeded	11s	View ↗
`nx run types:build`	✅ Succeeded	5s	View ↗
`nx run integration-tests:test`	✅ Succeeded	4s	View ↗
`nx run generate-configs`	✅ Succeeded	8s	View ↗
`Additional runs (29)`	✅ Succeeded	...	View ↗

☁️ Nx Cloud last updated this comment at 2025-11-04 13:14:21 UTC

nayounsang · 2025-06-21T11:18:39Z

Why tests was failed in CI?
In my local, there was no problem.

nayounsang · 2025-06-23T08:05:15Z

Can't reproduce test errors in local development.
In test, parseSettings.singleRun from packages/typescript-estree/src/parser.ts/parseAndGenerateServices is false.
So, it doesn't seem to be related to this commit.
I verified that the test results and (of course) the singleRun results did not change before and after the commit.
This work only affects singleRun.

packages/typescript-estree/src/parseSettings/inferSingleRun.ts

JamesHenry · 2025-07-15T19:29:35Z

@JoshuaKGoldberg @nayounsang Ok this one drove me a little insane working my way to a reproduction, but it actually has nothing to do with caching, it is all to do with whether CI=true is set or not (which is why it happens only on CI and not locally by default).

In other words, you should be able to repro with:

CI=true TYPESCRIPT_ESLINT_PROJECT_SERVICE=true nx test typescript-estree --skip-nx-cache

nayounsang · 2025-07-16T07:12:28Z

Thanks for helping us find the cause of this weird bug. Now let's fix our logic to fix the CI test failure.

codecov · 2025-07-18T14:19:18Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (5ec8c58) to head (b483190).
⚠️ Report is 176 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11327      +/-   ##
==========================================
- Coverage   90.86%   90.66%   -0.20%     
==========================================
  Files         503      518      +15     
  Lines       51028    52435    +1407     
  Branches     8418     8686     +268     
==========================================
+ Hits        46366    47541    +1175     
- Misses       4648     4880     +232     
  Partials       14       14

Flag	Coverage Δ
unittest	`90.66% <100.00%> (-0.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...escript-estree/src/parseSettings/inferSingleRun.ts	`100.00% <100.00%> (ø)`

... and 84 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ript-eslint into singlerun-true

nayounsang · 2025-07-19T14:40:10Z

Hi @JoshuaKGoldberg . Thank you for always helping me. I would like to ask you a question.
I want to test that singleRun works without any problems even when extraFileExtensions is set & projectService is truthy. But, I don't know how to write test scenarios and where to test them.

(I can see the processing extraFileExtensions logic in packages/typescript-estree/src/useProgramFromProjectService.ts
, but... I don't know if it's related to this issue.)

nayounsang · 2025-07-21T08:10:35Z

When singleRun & projectService is true and given extraFileExtensions in packages/typescript-estree/tests/lib/semanticInfo-singleRun.test.ts, check the program is generated.

const resultProgram = parseAndGenerateServices(code, options).services
        .program;
expect(resultProgram).toStrictEqual(mockProgram);

Because, the code is to solve the bug that occurs when programInstance is not found in the singleRun environment.

…service is true

nayounsang · 2025-07-21T08:50:11Z

packages/typescript-estree/tests/lib/semanticInfo-singleRun.test.ts

+  it('should create program when extraFileExtensions is provided in projectService and singleRun mode', () => {
+    vi.stubEnv('TSESTREE_SINGLE_RUN', 'true');
+
+    const resultProgram = parseAndGenerateServices(code, {


As asked, I'm not sure if testing like this is desirable.
parseAndGenerateService -> getProgramAndAST (in singleRun, get AST and program) -> useProgramFromProjectService -> extraFileExtensions

Yeah I'd remove this test change.

I committed

JoshuaKGoldberg

The first && added seems off to me, but the other looks good. Am I reading it right?

packages/typescript-estree/src/parseSettings/inferSingleRun.ts

JoshuaKGoldberg · 2025-09-03T11:34:27Z

packages/typescript-estree/tests/lib/semanticInfo-singleRun.test.ts

+  it('should create program when extraFileExtensions is provided in projectService and singleRun mode', () => {
+    vi.stubEnv('TSESTREE_SINGLE_RUN', 'true');
+
+    const resultProgram = parseAndGenerateServices(code, {


Yeah I'd remove this test change.

packages/typescript-estree/tests/lib/inferSingleRun.test.ts

packages/typescript-estree/src/parseSettings/inferSingleRun.ts

JoshuaKGoldberg

Ok I think we're pretty much there - just the one logical change. 🚀

packages/typescript-estree/src/parseSettings/inferSingleRun.ts

… truthy

JoshuaKGoldberg

✨ great, thanks!

Since I was so involved with this, someone else from @typescript-eslint/triage-team should probably take a look too.

nayounsang added 2 commits June 21, 2025 20:04

test: add test case

303c3ce

fix: return true for project service in single run

a2e2d21

nayounsang marked this pull request as draft June 21, 2025 11:14

nayounsang marked this pull request as ready for review June 23, 2025 08:07

JoshuaKGoldberg reviewed Jun 30, 2025

View reviewed changes

packages/typescript-estree/src/parseSettings/inferSingleRun.ts Show resolved Hide resolved

JamesHenry and others added 6 commits June 30, 2025 20:48

Merge branch 'main' into singlerun-true

490975a

Merge branch 'main' into singlerun-true

57db714

Merge branch 'main' into singlerun-true

f5a5215

Merge branch 'main' into singlerun-true

2e9f244

Merge branch 'main' into singlerun-true

fd15f0c

Merge branch 'main' into singlerun-true

1795e40

JoshuaKGoldberg added awaiting response Issues waiting for a reply from the OP or another party and removed awaiting response Issues waiting for a reply from the OP or another party labels Jul 14, 2025

Merge branch 'main' into singlerun-true

de26768

JamesHenry assigned JamesHenry and unassigned JamesHenry Jul 15, 2025

JamesHenry force-pushed the singlerun-true branch 2 times, most recently from fcdcb41 to de26768 Compare July 15, 2025 19:27

nayounsang added 2 commits July 16, 2025 16:12

Merge branch 'main' into singlerun-true

dd8f15e

Merge branch 'main' into singlerun-true

76502cf

nayounsang marked this pull request as draft July 18, 2025 11:22

fix: projectService being null is same as projectService is false

34cdad1

nayounsang and others added 4 commits July 18, 2025 23:49

feat: temp commit, bypass extraFileExtentions.length

b0dcd4a

Merge branch 'main' into singlerun-true

860d849

test: temp commit, add test for extraFileExtentions.length

b937bb7

Merge branch 'singlerun-true' of https://github.com/nayounsang/typesc…

48cd7c3

…ript-eslint into singlerun-true

test: more detail test name

ca1e819

test: generate program instance with extraFileExtensions when project…

9800aba

…service is true

nayounsang marked this pull request as ready for review July 21, 2025 08:45

nayounsang commented Jul 21, 2025

View reviewed changes

nayounsang requested a review from JoshuaKGoldberg July 21, 2025 08:50

JoshuaKGoldberg unassigned JamesHenry Aug 4, 2025

JoshuaKGoldberg requested changes Sep 3, 2025

View reviewed changes

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 3, 2025

nayounsang added 2 commits September 8, 2025 01:00

test: remove unneccesary tc

996b93b

fix: singleRun is false when project is truthy with extraFileExtentions

2933d52

nayounsang requested a review from JoshuaKGoldberg September 14, 2025 08:28

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Sep 14, 2025

JoshuaKGoldberg requested changes Sep 15, 2025

View reviewed changes

packages/typescript-estree/tests/lib/inferSingleRun.test.ts Outdated Show resolved Hide resolved

packages/typescript-estree/src/parseSettings/inferSingleRun.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Sep 15, 2025

test: rename test case

08838c5

JoshuaKGoldberg self-requested a review October 27, 2025 12:47

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Oct 27, 2025

JoshuaKGoldberg requested changes Nov 3, 2025

View reviewed changes

packages/typescript-estree/src/parseSettings/inferSingleRun.ts Outdated Show resolved Hide resolved

JoshuaKGoldberg added the awaiting response Issues waiting for a reply from the OP or another party label Nov 3, 2025

fix: infer singleRun as false whe extranFileExtensions and project is…

b483190

… truthy

nayounsang requested a review from JoshuaKGoldberg November 4, 2025 13:04

github-actions bot removed the awaiting response Issues waiting for a reply from the OP or another party label Nov 4, 2025

JoshuaKGoldberg approved these changes Nov 4, 2025

View reviewed changes

JoshuaKGoldberg added the 1 approval >=1 team member has approved this PR; we're now leaving it open for more reviews before we merge label Nov 4, 2025

Uh oh!

fix(typescript-estree): infers singleRun as true for project service #11327

Are you sure you want to change the base?

fix(typescript-estree): infers singleRun as true for project service #11327

Conversation

nayounsang commented Jun 21, 2025

PR Checklist

Overview

Uh oh!

typescript-eslint bot commented Jun 21, 2025

Uh oh!

netlify bot commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for typescript-eslint ready!

Uh oh!

nx-cloud bot commented Jun 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nayounsang commented Jun 21, 2025

Uh oh!

nayounsang commented Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

JamesHenry commented Jul 15, 2025

Uh oh!

nayounsang commented Jul 16, 2025

Uh oh!

codecov bot commented Jul 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nayounsang commented Jul 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nayounsang commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nayounsang Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

nayounsang Sep 14, 2025

Choose a reason for hiding this comment

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg Sep 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoshuaKGoldberg left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Jun 21, 2025 •

edited

Loading

nx-cloud bot commented Jun 21, 2025 •

edited

Loading

nayounsang commented Jun 23, 2025 •

edited

Loading

codecov bot commented Jul 18, 2025 •

edited

Loading

nayounsang commented Jul 19, 2025 •

edited

Loading

nayounsang commented Jul 21, 2025 •

edited

Loading

nayounsang Jul 21, 2025 •

edited

Loading

JoshuaKGoldberg left a comment •

edited

Loading