-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Open
Labels
package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-pluginpreset config changeProposal for an addition, removal, or general change to a preset configProposal for an addition, removal, or general change to a preset configteam assignedA member of the typescript-eslint team should work on this.A member of the typescript-eslint team should work on this.
Description
Before You File a Proposal Please Confirm You Have Done The Following...
- I have searched for related issues and found none that match my proposal.
- I have read the FAQ and my problem is not listed.
Description
Coming over from eslint/eslint#19173: the following non-type-aware extension rules are being replaced with core ESLint rules:
@typescript-eslint/class-methods-use-this@typescript-eslint/default-param-last@typescript-eslint/init-declarations@typescript-eslint/max-params@typescript-eslint/no-array-constructor@typescript-eslint/no-dupe-class-members@typescript-eslint/no-empty-function@typescript-eslint/no-invalid-this:@typescript-eslint/no-loop-func@typescript-eslint/no-loss-of-precision@typescript-eslint/no-magic-numbers@typescript-eslint/no-redeclare@typescript-eslint/no-restricted-imports@typescript-eslint/no-shadow@typescript-eslint/no-unused-expressions@typescript-eslint/no-unused-vars@typescript-eslint/no-use-before-define@typescript-eslint/no-useless-constructor
We're presumably going to want to:
- Deprecate these extension rules for the current major version
- File a followup breaking change issue to remove them in the next major that includes breaking changes
Proposal: let's tackle (1) once all the rules are implemented in ESLint core? That will cause less churn on our end and let us see what unexpected learnings, if any, are found in the still-pending ESLint rule updates.
Additional Info
💖
OlivierZal, kirkwaiblinger, ronami and zanminkianzanminkian
Metadata
Metadata
Assignees
Labels
package: eslint-pluginIssues related to @typescript-eslint/eslint-pluginIssues related to @typescript-eslint/eslint-pluginpreset config changeProposal for an addition, removal, or general change to a preset configProposal for an addition, removal, or general change to a preset configteam assignedA member of the typescript-eslint team should work on this.A member of the typescript-eslint team should work on this.