Fix assertion: class reference location may be 'default' keyword instead of class name (microsoft#21630)

Andy · web-flow · commit d584f4d97bdc · 2018-02-05T13:24:08.000-08:00
* Fix assertion: class reference location may be 'default' keyword instead of class name

* Update API baselines
diff --git a/src/compiler/types.ts b/src/compiler/types.ts
@@ -2027,6 +2027,7 @@ namespace ts {
 
     export interface ClassDeclaration extends ClassLikeDeclarationBase, DeclarationStatement {
         kind: SyntaxKind.ClassDeclaration;
+        /** May be undefined in `export default class { ... }`. */
         name?: Identifier;
     }
 
diff --git a/src/services/findAllReferences.ts b/src/services/findAllReferences.ts
@@ -990,7 +990,7 @@ namespace ts.FindAllReferences.Core {
         const pusher = () => state.referenceAdder(search.symbol, search.location);
 
         if (isClassLike(referenceLocation.parent)) {
-            Debug.assert(referenceLocation.parent.name === referenceLocation);
+            Debug.assert(referenceLocation.kind === SyntaxKind.DefaultKeyword || referenceLocation.parent.name === referenceLocation);
             // This is the class declaration containing the constructor.
             findOwnConstructorReferences(search.symbol, sourceFile, pusher());
         }
diff --git a/tests/baselines/reference/api/tsserverlibrary.d.ts b/tests/baselines/reference/api/tsserverlibrary.d.ts
@@ -1266,6 +1266,7 @@ declare namespace ts {
     }
     interface ClassDeclaration extends ClassLikeDeclarationBase, DeclarationStatement {
         kind: SyntaxKind.ClassDeclaration;
+        /** May be undefined in `export default class { ... }`. */
         name?: Identifier;
     }
     interface ClassExpression extends ClassLikeDeclarationBase, PrimaryExpression {
diff --git a/tests/baselines/reference/api/typescript.d.ts b/tests/baselines/reference/api/typescript.d.ts
@@ -1266,6 +1266,7 @@ declare namespace ts {
     }
     interface ClassDeclaration extends ClassLikeDeclarationBase, DeclarationStatement {
         kind: SyntaxKind.ClassDeclaration;
+        /** May be undefined in `export default class { ... }`. */
         name?: Identifier;
     }
     interface ClassExpression extends ClassLikeDeclarationBase, PrimaryExpression {
diff --git a/tests/cases/fourslash/findAllRefsExportDefaultClassConstructor.ts b/tests/cases/fourslash/findAllRefsExportDefaultClassConstructor.ts
@@ -0,0 +1,5 @@
+////export default class {
+////    [|constructor|]() {}
+////}
+
+verify.singleReferenceGroup("constructor default(): default");

Original file line number	Diff line number	Diff line change
`@@ -2027,6 +2027,7 @@ namespace ts {`
`2027`	`2027`
`2028`	`2028`	`export interface ClassDeclaration extends ClassLikeDeclarationBase, DeclarationStatement {`
`2029`	`2029`	`kind: SyntaxKind.ClassDeclaration;`
	`2030`	+ /** May be undefined in `export default class { ... }`. */
`2030`	`2031`	`name?: Identifier;`
`2031`	`2032`	`}`
`2032`	`2033`
Original file line number	Diff line number	Diff line change
`@@ -990,7 +990,7 @@ namespace ts.FindAllReferences.Core {`
`990`	`990`	`const pusher = () => state.referenceAdder(search.symbol, search.location);`
`991`	`991`
`992`	`992`	`if (isClassLike(referenceLocation.parent)) {`
`993`		`- Debug.assert(referenceLocation.parent.name === referenceLocation);`
	`993`	`+ Debug.assert(referenceLocation.kind === SyntaxKind.DefaultKeyword \|\| referenceLocation.parent.name === referenceLocation);`
`994`	`994`	`// This is the class declaration containing the constructor.`
`995`	`995`	`findOwnConstructorReferences(search.symbol, sourceFile, pusher());`
`996`	`996`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1266,6 +1266,7 @@ declare namespace ts {`
`1266`	`1266`	`}`
`1267`	`1267`	`interface ClassDeclaration extends ClassLikeDeclarationBase, DeclarationStatement {`
`1268`	`1268`	`kind: SyntaxKind.ClassDeclaration;`
	`1269`	+ /** May be undefined in `export default class { ... }`. */
`1269`	`1270`	`name?: Identifier;`
`1270`	`1271`	`}`
`1271`	`1272`	`interface ClassExpression extends ClassLikeDeclarationBase, PrimaryExpression {`