feat: UpdateResult returns affected rows in mysql (#5628)

weeix · web-flow · commit 17f2fff359f8 · 2020-03-11T18:01:28.000+05:00
Set 'affected' property for 'UpdateResult' returned by MySQL Closes: #1308
diff --git a/src/query-builder/UpdateQueryBuilder.ts b/src/query-builder/UpdateQueryBuilder.ts
@@ -104,6 +104,10 @@ export class UpdateQueryBuilder<Entity> extends QueryBuilder<Entity> implements
                 updateResult.raw = result[0];
                 updateResult.affected = result[1];
             }
+            else if (this.connection.driver instanceof MysqlDriver) {
+                updateResult.raw = result;
+                updateResult.affected = result.affectedRows;
+            }
             else {
                 updateResult.raw = result;
             }
diff --git a/test/github-issues/1308/issue-1308.ts b/test/github-issues/1308/issue-1308.ts
@@ -11,7 +11,7 @@ describe("github issues > #1308 Raw Postgresql Update query result is always an
       (connections = await createTestingConnections({
         entities: [new EntitySchema<Author>(AuthorSchema), new EntitySchema<Post>(PostSchema)],
         dropSchema: true,
-        enabledDrivers: ["postgres"],
+        enabledDrivers: ["postgres", "mysql", "mariadb"],
       }))
   );
   beforeEach(() => reloadTestingDatabases(connections));

Original file line number	Diff line number	Diff line change
`@@ -104,6 +104,10 @@ export class UpdateQueryBuilder<Entity> extends QueryBuilder<Entity> implements`
`104`	`104`	`updateResult.raw = result[0];`
`105`	`105`	`updateResult.affected = result[1];`
`106`	`106`	`}`
	`107`	`+ else if (this.connection.driver instanceof MysqlDriver) {`
	`108`	`+ updateResult.raw = result;`
	`109`	`+ updateResult.affected = result.affectedRows;`
	`110`	`+ }`
`107`	`111`	`else {`
`108`	`112`	`updateResult.raw = result;`
`109`	`113`	`}`