FIX: get_all_page fetch all tables according to NEXT_PAGE_TOKEN #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigquery/client.py
Outdated
Owner
There was a problem hiding this comment.
Can just be if cache instead of if cache is True.
Likewise, I think we can just do the truthy if self.cache.get(dataset_id) instead of is not None.
Owner
|
Looks good other than minor style nitpicks. Might be out of scope for this PR, but it could be useful to provide an API to allow users to page over dataset tables. |
bigquery/client.py
Outdated
Owner
There was a problem hiding this comment.
This looks like a typo: nextPageToekn
Owner
There was a problem hiding this comment.
Also, if we use while page_token for the loop, this can just be res.get('nextPageToken'). Likewise for the initial assignment of page_token on line 817.
tylertreat
added a commit
that referenced
this pull request
Dec 23, 2014
FIX: get_all_page fetch all tables according to NEXT_PAGE_TOKEN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue where there are many tables in a dataset, get_all_tables() would only return a subset of all the tables.
Also added cache option to get_all_tables().