refactored to class #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickStrick
approved these changes
Mar 1, 2019
NickStrick
left a comment
NickStrick
left a comment
There was a problem hiding this comment.
Looks really good! Demonstrated The concepts really well.
just try and get in the midset of thinking about the relationships between classes, and what exactly each class needs in terms on attributes and methods/data.
|
|
||
| // student class | ||
|
|
||
| class Student extends Instructor { |
There was a problem hiding this comment.
student should be an extend Person no Instructor, because we dont want Student to have the attributes of Instructor, just those of Person.
Suggested change
| class Student extends Instructor { | |
| class Student extends Person{ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.