Skip to content

Conversation

@toughyear
Copy link

@toughyear toughyear commented Sep 4, 2024

The existing implementation overrides the default options with the new ones if provided. In that case, if partial options are provided, this can lead to unexpected errors (Null values in return object) because default values are all reset.

Problem

The existing implementation overrides the default options with the new ones if provided. In that case, if partial options are provided, this can lead to unexpected errors (Null values in return object) because default values are all reset.

Solution

Merge correctly such that partial options provided are merged with correct defaults keeping the output sane.

Result

fixes the parseTweet function when partial options are provided.

The existing implementation overrides the default options with the new ones if provided. In that case, if partial options are provided, this can lead to unexpected errors (Null values in return object) because default values are all reset.
@CLAassistant
Copy link

CLAassistant commented Sep 4, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants