Skip to content

[JS] - When defaulting do not merge objects - #276

Merged
leeaustinadams merged 6 commits into
twitter:masterfrom
kaushlakers:master
Dec 18, 2018
Merged

[JS] - When defaulting do not merge objects#276
leeaustinadams merged 6 commits into
twitter:masterfrom
kaushlakers:master

Conversation

@kaushlakers

Copy link
Copy Markdown
Contributor

Problem
When we set the config version 3 as default we broke v2 counting because we merge the passed in config with the default config. Now since emojiParsingEnabled is a new field, when we merge objects with the default config, it is always enabled

Solution
Don't merge configs. Only set to default it if we don't have anything in the config

Result
After the 3.0 release, v2 counting was broken. Now it will work again if it is explicitly passed.

Misc Changes:

  • Explicitly remove some files that were supposed to be deleted in the 3.0 commit. They stayed around because of the github merges missing files in your commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants