Skip to content

Commit c849fcd

Browse files
Merge pull request DataDog#2597 from DataDog/ban/remove-caffeine-weak-cache
Remove Caffeine Weak Cache Provider
2 parents 0bf3c33 + 8612757 commit c849fcd

File tree

4 files changed

+3
-123
lines changed

4 files changed

+3
-123
lines changed

dd-java-agent/agent-tooling/agent-tooling.gradle

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -3,18 +3,6 @@ apply from: "$rootDir/gradle/java.gradle"
33
minimumBranchCoverage = 0.6
44
excludedClassesCoverage += ['datadog.trace.agent.tooling.*']
55

6-
// patch inner class from Caffeine to avoid ForkJoinTask from being loaded too early
7-
sourceSets {
8-
patch {
9-
java {}
10-
}
11-
}
12-
jar {
13-
from(sourceSets.patch.output) {
14-
include 'com/github/benmanes/caffeine/cache/BoundedLocalCache$PerformCleanupTask.class'
15-
}
16-
}
17-
186
configurations {
197
// classpath used by the instrumentation muzzle plugin
208
instrumentationMuzzle
@@ -26,10 +14,6 @@ dependencies {
2614
}
2715
compile group: 'com.blogspot.mydailyjava', name: 'weak-lock-free', version: '0.17'
2816
compile group: 'com.googlecode.concurrentlinkedhashmap', name: 'concurrentlinkedhashmap-lru', version: '1.4.2'
29-
compile(group: 'com.github.ben-manes.caffeine', name: 'caffeine', version: '2.8.6') {
30-
exclude group: 'com.google.errorprone', module: 'error_prone_annotations'
31-
exclude group: 'org.checkerframework', module: 'checker-qual'
32-
}
3317
compile deps.bytebuddy
3418
compile deps.bytebuddyagent
3519

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/AgentTooling.java

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@
33
import datadog.trace.agent.tooling.bytebuddy.DDCachingPoolStrategy;
44
import datadog.trace.agent.tooling.bytebuddy.DDLocationStrategy;
55
import datadog.trace.api.Config;
6-
import datadog.trace.api.Platform;
76
import datadog.trace.bootstrap.WeakCache;
87
import datadog.trace.bootstrap.WeakCache.Provider;
98
import datadog.trace.bootstrap.WeakMap;
@@ -32,17 +31,9 @@ private static Provider loadWeakCacheProvider() {
3231
Class<Provider> providerClass;
3332

3433
try {
35-
if (Platform.isJavaVersionAtLeast(8)) {
36-
providerClass =
37-
(Class<Provider>)
38-
classLoader.loadClass("datadog.trace.agent.tooling.CaffeineWeakCache$Provider");
39-
log.debug("Using CaffeineWeakCache Provider");
40-
} else {
41-
providerClass =
42-
(Class<Provider>)
43-
classLoader.loadClass("datadog.trace.agent.tooling.CLHMWeakCache$Provider");
44-
log.debug("Using CLHMWeakCache Provider");
45-
}
34+
providerClass =
35+
(Class<Provider>)
36+
classLoader.loadClass("datadog.trace.agent.tooling.CLHMWeakCache$Provider");
4637

4738
return providerClass.getDeclaredConstructor().newInstance();
4839
} catch (ReflectiveOperationException e) {

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/CaffeineWeakCache.java

Lines changed: 0 additions & 53 deletions
This file was deleted.

dd-java-agent/agent-tooling/src/patch/java/com/github/benmanes/caffeine/cache/BoundedLocalCache.java

Lines changed: 0 additions & 42 deletions
This file was deleted.

0 commit comments

Comments
 (0)