Kafka Streams: remove span/scope from task

tylerbenson · tylerbenson · commit b16632b499c0 · 2021-08-19T10:24:16.000-04:00
When finishing the span, remove it to allow it to be GC'd and not linger.  Don't think it's causing any problems... just more sanitary.
diff --git a/dd-java-agent/instrumentation/kafka-streams-0.11/src/main/java/datadog/trace/instrumentation/kafka_streams/KafkaStreamTaskInstrumentation.java b/dd-java-agent/instrumentation/kafka-streams-0.11/src/main/java/datadog/trace/instrumentation/kafka_streams/KafkaStreamTaskInstrumentation.java
@@ -166,7 +166,8 @@ public static class StopSpanAdvice {
     @Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
     public static void stop(
         @Advice.Thrown final Throwable throwable, @Advice.This StreamTask task) {
-      AgentScope scope = InstrumentationContext.get(StreamTask.class, AgentScope.class).get(task);
+      AgentScope scope =
+          InstrumentationContext.get(StreamTask.class, AgentScope.class).remove(task);
       if (scope != null) {
         AgentSpan span = scope.span();
         CONSUMER_DECORATE.onError(span, throwable);
