Skip to content

Conversation

@KATT
Copy link
Member

@KATT KATT commented Dec 19, 2025

Summary by CodeRabbit

  • Chores

    • Updated project to a newer pnpm release for dependency management.
    • Removed Node.js engine constraint and explicit package manager setting from the example starter for broader compatibility.
  • Tests

    • Standardized test coverage output directory and CI configured to upload coverage reports.

✏️ Tip: You can customize this high-level summary in your review settings.

@KATT KATT requested a review from a team as a code owner December 19, 2025 14:56
@railway-app
Copy link

railway-app bot commented Dec 19, 2025

🚅 Deployed to the trpc-pr-7060 environment in trpc-sse-and-websockets

Service Status Web Updated (UTC)
next-sse-chat 😴 Sleeping (View Logs) Web Dec 20, 2025 at 11:48 pm
next-prisma-websockets-starter 😴 Sleeping (View Logs) Dec 20, 2025 at 11:43 pm

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 19, 2025

Walkthrough

Removed Node engine and example packageManager declarations; bumped root pnpm to ^10.26.1 and packageManager to pnpm@10.26.1; added Vitest coverage reportsDirectory and a Codecov upload pattern for ./coverage/**/*.json.

Changes

Cohort / File(s) Change Summary
Example package.json cleanup
examples/next-prisma-websockets-starter/package.json
Removed engines.node (>=18.15.0) and removed packageManager (pnpm@9.12.2).
Root pnpm version upgrade
package.json
Bumped engines.pnpm from ^9.12.2 to ^10.26.1 and updated packageManager from pnpm@9.12.2 to pnpm@10.26.1.
Coverage reporting config
.github/workflows/main.yml, vitest.config.ts
Added Codecov upload files: ./coverage/**/*.json; added test.coverage.reportsDirectory: './coverage' in Vitest config.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Verify CI and local compatibility with pnpm v10 (root package.json).
  • Check that removing engines.node and example packageManager doesn't break the example or its docs.
  • Confirm Vitest writes reports to ./coverage and Codecov uploads the ./coverage/**/*.json artifacts as expected.

Suggested reviewers

  • juliusmarminge

Poem

🐇 I nibbled at package fields, neat and bright,
Tossed old constraints into the night,
Coverage found a cozy, new domain,
pnpm climbed up a versioned train,
Hops and bytes — a tidy delight.

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is completely empty, missing all required sections including the issue reference, changes explanation, and checklist items from the repository template. Provide a complete description following the template: include issue reference, explain the changes (pnpm bump rationale), and complete the checklist items.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: bump pnpm' accurately reflects the main changes: updating pnpm from version 9.12.2 to 10.26.1 across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 12-19-tweakies

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between abb51fb and 86d3ba0.

📒 Files selected for processing (1)
  • examples/next-prisma-websockets-starter/package.json (0 hunks)
💤 Files with no reviewable changes (1)
  • examples/next-prisma-websockets-starter/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: E2E-tests (standalone-server)
  • GitHub Check: E2E-tests (next-formdata)
  • GitHub Check: E2E-tests (.test/internal-types-export)
  • GitHub Check: E2E-tests (express-minimal)
  • GitHub Check: E2E-tests (fastify-server)
  • GitHub Check: E2E-tests (cloudflare-workers)
  • GitHub Check: e2e-legacy-node (next-prisma-starter, 18.x)
  • GitHub Check: e2e-legacy-node (next-prisma-websockets-starter, 20.x)
  • GitHub Check: e2e-legacy-node (next-prisma-todomvc, 20.x)
  • GitHub Check: e2e-legacy-node (next-prisma-starter, 20.x)
  • GitHub Check: e2e-legacy-node (next-prisma-todomvc, 18.x)
  • GitHub Check: Test a monorepo using built declaration files
  • GitHub Check: e2e-legacy-node (next-prisma-websockets-starter, 18.x)
  • GitHub Check: E2E-tests (Deno) (deno-deploy)
  • GitHub Check: typecheck-www
  • GitHub Check: Release using pkg.pr.new
  • GitHub Check: E2E-tests (Bun) (bun, ubuntu-latest)
  • GitHub Check: Lint and auto-fix
  • GitHub Check: test

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
Copy link

vercel bot commented Dec 19, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
next-prisma-starter Ready Ready Preview Dec 20, 2025 11:29pm
og-image Ready Ready Preview, Comment Dec 20, 2025 11:29pm

trpc-bot
trpc-bot previously approved these changes Dec 19, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 19, 2025

Open in StackBlitz

@trpc/client

npm i https://pkg.pr.new/trpc/trpc/@trpc/client@7060

@trpc/next

npm i https://pkg.pr.new/trpc/trpc/@trpc/next@7060

@trpc/react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/react-query@7060

@trpc/server

npm i https://pkg.pr.new/trpc/trpc/@trpc/server@7060

@trpc/tanstack-react-query

npm i https://pkg.pr.new/trpc/trpc/@trpc/tanstack-react-query@7060

@trpc/upgrade

npm i https://pkg.pr.new/trpc/trpc/@trpc/upgrade@7060

commit: d1c659c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants