Skip to content

Trang Do | Oct2025-1 | Data Groups | Sprint 3 | Quote Generator#4

Open
trngdothuy wants to merge 7 commits intomainfrom
feature/quote-generator
Open

Trang Do | Oct2025-1 | Data Groups | Sprint 3 | Quote Generator#4
trngdothuy wants to merge 7 commits intomainfrom
feature/quote-generator

Conversation

@trngdothuy
Copy link
Owner

@trngdothuy trngdothuy commented Jan 24, 2026

✅ Self-Checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR based on the guideline
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task
  • I have checked all acceptance criteria

🔄 Changelist

  • I created generateQuote(), buttonClicked(), checkboxClicked() function in quotes.js
  • I added HTML elements checkbox and div
  • I updated CSS

❓ Questions

Please help me check my code writing and advise me on how to improve it. Right now, the test doesn't pass since I added the function of auto-play, I think it's because the 1st random quote is not the same as before due to random choosing, but I'm not sure. Can you suggest to me why the test didn't pass? Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant