feat: modernise, drop support for php < 7.4, migrate tests and config for phpUnit 9, replace travis with github actions

Chris8934 · Chris8934 · commit 90f90578c876 · 2023-11-02T11:52:40.000+01:00
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -0,0 +1,58 @@
+# .github/workflows/code_checks.yaml
+name: Code_Checks
+
+on: ["push", "pull_request"]
+
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        php: ['7.4']
+        stability: [ prefer-stable ]
+        experimental: [false]
+        include:
+          - php: '7.4'
+            stability: prefer-lowest
+          - php: '8.0'
+          - php: '8.1'
+          - php: '8.2'
+          - php: '8.3'
+
+    name: PHP ${{ matrix.php }} - ${{ matrix.stability }} tests
+    steps:
+      # basically git clone
+      - uses: actions/checkout@v4
+
+      - name: Cache dependencies
+        uses: actions/cache@v3
+        with:
+          path: ~/.composer/cache/files
+          key: dependencies-php-${{ matrix.php }}-composer-${{ hashFiles('composer.json') }}
+
+      # use PHP of specific version
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          extensions: pcov
+          coverage: pcov
+
+      - name: Install dependencies
+        run: |
+          composer install --verbose --prefer-dist --no-interaction -o
+
+      - name: Execute tests
+        run: vendor/bin/phpunit -c ./tests/phpunit.xml.dist ./tests --verbose
+
+  cs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: shivammathur/setup-php@v2
+        with:
+          php-version: 8.2
+          coverage: none # disable xdebug, pcov
+      - run: composer install --no-progress
+      - run: ./vendor/bin/phpcs --encoding=utf-8 --extensions=php --standard=./tests/phpcs.xml -nsp ./
+
diff --git a/.travis.yml b/.travis.yml
diff --git a/composer.json b/composer.json
@@ -32,7 +32,7 @@
 
     "require-dev": {
         "phpunit/phpunit":           "^9.5",
-        "squizlabs/php_codesniffer": "^2.8.1"
+        "squizlabs/php_codesniffer": "^3.7"
     },
 
     "replace": {
diff --git a/tests/AbstractPhysicalQuantityTest.php b/tests/AbstractPhysicalQuantityTest.php
@@ -111,8 +111,7 @@ public function testConvertToUnknownUnitThrowsException(
         AbstractPhysicalQuantity $value,
         $arbitraryUnit,
         $valueInArbitraryUnit
-    ): void
-    {
+    ): void {
         $this->expectException(\PhpUnitsOfMeasure\Exception\UnknownUnitOfMeasure::class);
         $value->toUnit('someUnknownUnit');
     }
@@ -125,8 +124,7 @@ public function testUnitConvertsToArbitraryUnit(
         AbstractPhysicalQuantity $value,
         $arbitraryUnit,
         $valueInArbitraryUnit
-    ): void
-    {
+    ): void {
         $this->assertSame($valueInArbitraryUnit, $value->toUnit($arbitraryUnit));
     }
 
@@ -146,8 +144,7 @@ public function testSerialize(
         AbstractPhysicalQuantity $value,
         $arbitraryUnit,
         $valueInArbitraryUnit
-    ): void
-    {
+    ): void {
         serialize($value);
     }
 
@@ -158,8 +155,7 @@ public function testUnserialize(
         AbstractPhysicalQuantity $value,
         $arbitraryUnit,
         $valueInArbitraryUnit
-    ): void
-    {
+    ): void {
         $unserializedValue = unserialize(serialize($value));
 
         $this->assertSame($valueInArbitraryUnit, $unserializedValue->toUnit($arbitraryUnit));
@@ -175,8 +171,7 @@ public function testAdd(
         AbstractPhysicalQuantity $secondValue,
         $sumString,
         $diffString
-    ): void
-    {
+    ): void {
         if ($shouldThrowException) {
             $this->expectException(PhysicalQuantityMismatch::class);
         }
@@ -198,11 +193,9 @@ public function testSubtract(
         AbstractPhysicalQuantity $secondValue,
         $sumString,
         $diffString
-    ): void
-    {
+    ): void {
         if ($shouldThrowException) {
             $this->expectException(PhysicalQuantityMismatch::class);
-
         }
 
         $difference = $firstValue->subtract($secondValue);
