Skip to content

Commit 115b5cb

Browse files
committed
only test php 7.4 at this point
1 parent 754aa30 commit 115b5cb

File tree

7 files changed

+22
-13
lines changed

7 files changed

+22
-13
lines changed

.github/workflows/php.yml

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,13 @@ jobs:
1515
fail-fast: false
1616
matrix:
1717
operating-system: [ubuntu-latest]
18-
php-versions: ['7.4', '8.0', '8.1', '8.2', '8.3', '8.4']
18+
php-versions:
19+
- '7.4'
20+
# - '8.0'
21+
# - '8.1'
22+
# - '8.2'
23+
# - '8.3'
24+
# - '8.4'
1925

2026
name: PHP ${{ matrix.php-versions }} Test on ${{ matrix.operating-system }}
2127

Dockerfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,4 +8,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
88

99
RUN curl -sS https://getcomposer.org/installer | php -- --install-dir=/usr/local/bin && ln -s /usr/local/bin/composer.phar /usr/local/bin/composer
1010

11+
RUN git config --global --add safe.directory /project
12+
1113
WORKDIR /project

composer.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
"php": ">=7.4.0"
2323
},
2424
"require-dev": {
25-
"phpunit/phpunit": "4.8.*",
25+
"phpunit/phpunit": "5.*",
2626
"squizlabs/php_codesniffer": "3.7.2"
2727
},
2828
"replace": {

tests/AbstractPhysicalQuantityTest.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace PhpUnitsOfMeasureTest;
44

5-
use PHPUnit_Framework_TestCase;
5+
use PHPUnit\Framework\TestCase;
66
use PhpUnitsOfMeasure\AbstractPhysicalQuantity;
77
use PhpUnitsOfMeasure\UnitOfMeasureInterface;
88
use PhpUnitsOfMeasure\Exception\PhysicalQuantityMismatch;
@@ -20,7 +20,7 @@
2020
*
2121
* @runTestsInSeparateProcesses
2222
*/
23-
class AbstractPhysicalQuantityTest extends PHPUnit_Framework_TestCase
23+
class AbstractPhysicalQuantityTest extends \PHPUnit\Framework\TestCase
2424
{
2525
protected function getTestUnitOfMeasure($name, $aliases = [])
2626
{
@@ -230,26 +230,26 @@ public function testIsUnitDefined()
230230
{
231231
$newUnit = $this->getTestUnitOfMeasure('noconflict', ['definitelynoconflict_1', 'definitelynoconflict_2']);
232232
Wonkicity::addUnit($newUnit);
233-
233+
234234
$someExistingUnits = ['u', 'uvees', 'v', 'vorp', 'noconflict', 'definitelynoconflict_1', 'definitelynoconflict_2'];
235235
$unexistingUnits = ['kg', 'l', 'definitelynoconflict_'];
236-
236+
237237
foreach ($someExistingUnits as $someExistingUnit) {
238238
$this->assertTrue(Wonkicity::isUnitDefined($someExistingUnit), "$someExistingUnit is not defined");
239239
}
240240
foreach ($unexistingUnits as $unexistingUnit) {
241241
$this->assertFalse(Wonkicity::isUnitDefined($unexistingUnit), "$unexistingUnit is not defined");
242242
}
243243
}
244-
244+
245245
/**
246246
* @covers \PhpUnitsOfMeasure\AbstractPhysicalQuantity::listAllUnits
247247
*/
248248
public function testListAllUnits()
249249
{
250250
$newUnit = $this->getTestUnitOfMeasure('noconflict', ['definitelynoconflict_1', 'definitelynoconflict_2']);
251251
Wonkicity::addUnit($newUnit);
252-
252+
253253
$allUnits = Wonkicity::listAllUnits();
254254
$expected = [];
255255
$expected['u'] = ['uvee', 'uvees'];

tests/DemonstrationTests.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
namespace PhpUnitsOfMeasureTest;
44

5-
use PHPUnit_Framework_TestCase;
5+
use PHPUnit\Framework\TestCase;
66

77
use PhpUnitsOfMeasure\UnitOfMeasure;
88
use PhpUnitsOfMeasure\AbstractDerivedPhysicalQuantity;
@@ -32,7 +32,7 @@
3232
*
3333
* @runTestsInSeparateProcesses
3434
*/
35-
class DemonstrationTests extends PHPUnit_Framework_TestCase
35+
class DemonstrationTests extends \PHPUnit\Framework\TestCase
3636
{
3737
public function testInstantiatingQuantities()
3838
{

tests/PhysicalQuantity/AbstractPhysicalQuantityTestCase.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22

33
namespace PhpUnitsOfMeasureTest\PhysicalQuantity;
44

5-
use PHPUnit_Framework_TestCase;
5+
use PHPUnit\Framework\TestCase;
66

77
/**
88
* This is a parent class for all the PhysicalQuantity childrens' test cases.
99
*/
10-
abstract class AbstractPhysicalQuantityTestCase extends PHPUnit_Framework_TestCase
10+
abstract class AbstractPhysicalQuantityTestCase extends \PHPUnit\Framework\TestCase
1111
{
1212
protected $supportedUnitsWithAliases = [];
1313

tests/UnitOfMeasureTest.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,10 @@
22

33
namespace PhpUnitsOfMeasureTest;
44

5+
use PHPUnit\Framework\TestCase;
56
use PhpUnitsOfMeasure\UnitOfMeasure;
67

7-
class UnitOfMeasureTest extends \PHPUnit_Framework_TestCase
8+
class UnitOfMeasureTest extends \PHPUnit\Framework\TestCase
89
{
910
/**
1011
* @covers \PhpUnitsOfMeasure\UnitOfMeasure::__construct

0 commit comments

Comments
 (0)