This repository was archived by the owner on Dec 11, 2023. It is now read-only.
remove the unnecessary argument in the CreateTrigger func in wiretap#337
Merged
tzununbekov merged 1 commit intotriggermesh:mainfrom Jun 20, 2023
Merged
remove the unnecessary argument in the CreateTrigger func in wiretap#337tzununbekov merged 1 commit intotriggermesh:mainfrom
tzununbekov merged 1 commit intotriggermesh:mainfrom
Conversation
Contributor
Author
|
Hey, @tzununbekov |
tzununbekov
reviewed
Jun 20, 2023
Member
tzununbekov
left a comment
tzununbekov
left a comment
There was a problem hiding this comment.
Could you remove the eventTypes flag from the watch.go arguments, as well as EventTypes and Source attributes from the CliOptions structure to make this cleanup complete?
tzununbekov
approved these changes
Jun 20, 2023
Member
tzununbekov
left a comment
tzununbekov
left a comment
There was a problem hiding this comment.
Doc for the watch command needs to be updated, otherwise, CI won't pass
Signed-off-by: Nikhil Sharma <nikhilsharma230303@gmail.com>
tzununbekov
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CreateTrigger function has an unnecessary parameter.
Maybe forgot to remove it after the function structure was changed.