-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
fix(sdk): preserve partial assistant message on chat stream failure #4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
matt-aitken
wants to merge
13
commits into
main
Choose a base branch
from
fix/chat-preserve-partial-on-stream-failure
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+596
−24
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8152444
fix(sdk): preserve partial assistant message on chat stream failure
matt-aitken dc63a6e
fix(sdk): persist recovered partial to accumulator and snapshot on error
matt-aitken 1fe685c
fix(sdk): mirror success-path accumulation on chat.agent error path
matt-aitken b6ea02f
fix(sdk): don't overwrite a committed response when a post-response s…
matt-aitken a225c36
fix(sdk): include the recovered partial in the error event's newMessages
matt-aitken 882364a
fix(sdk): harden error-path partial recovery against fragment clobber…
matt-aitken ec33b97
fix(sdk): preserve stream backpressure when tapping chat chunks
matt-aitken 6aeb2b9
fix(sdk): clean incomplete parts from the recovered error partial
matt-aitken ecfede6
perf(sdk): release the chat chunk buffer once the response is committed
matt-aitken 1916507
fix(sdk): preserve compaction and avoid double-persist on the error path
matt-aitken b5c37ee
fix(sdk): include the errored user message in the error event's newMe…
matt-aitken aaa51a3
fix(sdk): fold queued response data parts into the managed error partial
matt-aitken 0316b05
fix(sdk): satisfy the package build's stricter null-narrowing on the …
matt-aitken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@trigger.dev/sdk": patch | ||
| --- | ||
|
|
||
| Preserve the partial assistant message when a chat turn's model stream fails mid-response (e.g. a transport timeout). Previously the streamed-so-far output was dropped: `chat.agent`'s `onTurnComplete` fired with `responseMessage: undefined`, and `chat.createSession`'s `turn.complete()` rethrew without keeping the partial. Now the recovered partial is passed to `onTurnComplete` (on `responseMessage`, `uiMessages`, and `newUIMessages`) and accumulated before `turn.complete()` rethrows, so it survives for persistence even when `hydrateMessages` disables boot-time replay recovery. The turn is still reported as errored. |
|
matt-aitken marked this conversation as resolved.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.