Skip to content

fix(core): enforce maxElapsed against wall-clock in ExponentialBackoff.execute #4298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ANSHSINGH050404 wants to merge 1 commit into from
Closed

fix(core): enforce maxElapsed against wall-clock in ExponentialBackoff.execute #4298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/backoff-maxelapsed-wallclock.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@trigger.dev/core": patch
---

Honor `maxElapsed` against real wall-clock time in `ExponentialBackoff.execute()`, including time spent inside the callback—not only sleep delays.
12 changes: 12 additions & 0 deletions packages/core/src/v3/apps/backoff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,15 +290,27 @@ export class ExponentialBackoff {
> {
let elapsedMs = 0;
let finalError: unknown = undefined;
// maxElapsed is in seconds (see class docs). Enforce wall-clock time for
// the whole execute() loop (sleeps + callbacks), not only sleep delays.
const maxElapsedMs = this.#maxElapsed * 1000;
const wallStart = Date.now();

for await (const { delay, retry } of this) {
if (Date.now() - wallStart > maxElapsedMs) {
break;
}

const start = Date.now();

if (retry > 0) {
console.log(`Retrying in ${delay.milliseconds}ms`);
await timeout(delay.milliseconds);
}

if (Date.now() - wallStart > maxElapsedMs) {
break;
}

let attemptTimeout: NodeJS.Timeout | undefined = undefined;

try {
Expand Down