Skip to content

fix(webapp): escape single quotes in realtime tags filter #4296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ANSHSINGH050404 wants to merge 1 commit into from
Closed

fix(webapp): escape single quotes in realtime tags filter #4296

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .server-changes/fix-realtime-tags-sql-escape.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
area: webapp
type: fix
---

Hardened realtime run filtering so special characters in tags cannot interfere with the query.
5 changes: 4 additions & 1 deletion apps/webapp/app/services/realtimeClient.server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ export class RealtimeClient {
const whereClauses: string[] = [`"runtimeEnvironmentId"='${environment.id}'`];

if (params.tags) {
whereClauses.push(`"runTags" @> ARRAY[${params.tags.map((t) => `'${t}'`).join(",")}]`);
// Escape single quotes so user-provided tags cannot break out of the
// ARRAY literal (Electric WHERE clause is string-interpolated).
const escapedTags = params.tags.map((t) => `'${t.replace(/'/g, "''")}'`).join(",");
whereClauses.push(`"runTags" @> ARRAY[${escapedTags}]`);
}

const createdAtFilter = await this.#calculateCreatedAtFilter(url, params.createdAt);
Expand Down