fix(webapp): convert epoch-ms to BigInt before nanosecond multiply#4295
fix(webapp): convert epoch-ms to BigInt before nanosecond multiply#4295ANSHSINGH050404 wants to merge 1 commit into
Conversation
Avoids IEEE 754 precision loss when ms * 1e6 exceeds Number.MAX_SAFE_INTEGER. Closes triggerdotdev#3292
|
|
Hi @ANSHSINGH050404, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughTimestamp calculations now convert millisecond values to ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
Closes #3292
Checklist
Summary
ms * 1_000_000exceedsNumber.MAX_SAFE_INTEGERand loses precision before BigInt conversion.Fix
BigInt(ms) * BigInt(1_000_000)in event repository helpers and run engine handlers.Vouch request: #4290