fix(cli): strip workspaces from package.json before bun install#3290
fix(cli): strip workspaces from package.json before bun install#3290cyphercodes wants to merge 1 commit intotriggerdotdev:mainfrom
Conversation
Bun strictly validates that all workspaces exist before installing, unlike npm/node which just warns. This causes deployments to fail with 'Workspace not found' error when using runtime: 'bun' in projects with workspaces defined in package.json. The fix strips the workspaces field from package.json before running bun install, preventing the validation error. Fixes triggerdotdev#3272
|
|
Hi @cyphercodes, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/triggerdotdev/trigger.dev/blob/main/CONTRIBUTING.md for more details. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe build process for the Bun-based Docker stage has been modified to include an additional step that removes the Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
1 participant
Bun strictly validates that all workspaces exist before installing, unlike npm/node which just warns. This causes deployments to fail with 'Workspace not found' error when using runtime: 'bun' in projects with workspaces defined in package.json.
The fix strips the workspaces field from package.json before running bun install, preventing the validation error.
Fixes #3272