Repository navigation
fix(trie): delete words containing supplementary Unicode characters - #2239
Open
Shubham-Padkonde wants to merge 1 commit into
Open
Shubham-Padkonde wants to merge 1 commit into
Shubham-Padkonde wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deleting a word containing a supplementary Unicode character currently leaves it in the trie. Insertion and lookup iterate code points, but deletion indexes UTF-16 code units and cannot find the corresponding child.
Use
Array.from(word)consistently during deletion. The regression covers emoji at the start and end of words, shared prefixes, a non-emoji supplementary character, a missing word, and cleanup after all words are deleted. It fails before the fix.Fixes #2237.
Validation:
npm run lintand the complete Jest coverage suite pass. Trie.js retains 100% statement, branch, function, and line coverage.AI-assisted contribution.